-
Notifications
You must be signed in to change notification settings - Fork 3
Crowdloan pallet tests #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dhirajs0
wants to merge
19
commits into
main
Choose a base branch
from
crowdloan_pallet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x3c41a
reviewed
Aug 27, 2025
x3c41a
reviewed
Aug 27, 2025
x3c41a
reviewed
Aug 27, 2025
1a8d9b6 to
056770c
Compare
5d26e25 to
9fbf243
Compare
dhirajs0
commented
Oct 31, 2025
migration-tests/pallets/crowdloan.ts
Outdated
Comment on lines
270
to
271
| // countOfMissingCrowdloanReserves should be equal 1 for bifrost (para_id 3356) - for Polkadot. | ||
| assert.equal(countOfMissingCrowdloanReserves, 1, `Count of missing crowdloan reserves should be 1 beacuse of bifrost (para_id 3356) for Polkadot but found ${countOfMissingCrowdloanReserves}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verifies that it fails for only one entry( i.e bifrost) as pointed by Oliver
I think you can replicate the test and see that it only fails in one entry
|
PR #270 is verifying the contribution related tests as that required extrinsic calls and state mutations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crowdloan Pallet migration tests
This will close issue #153
I have tested it on post migration snapshot from ci run 18856970433, it's on post migration snapshot of polkadot