Skip to content

Stability: OS signals #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hug-dev opened this issue Apr 14, 2021 · 2 comments
Closed

Stability: OS signals #395

hug-dev opened this issue Apr 14, 2021 · 2 comments
Assignees
Labels
stability Issues related to the stability of the service

Comments

@hug-dev
Copy link
Member

hug-dev commented Apr 14, 2021

Definition: OS signals should still have the same behaviour in future stable Parsec versions.
Enforcement: Signal handlers must not be removed in Parsec.

Enforcement Check

Parsec currently answers to SIGTERM and SIGKILL. Those signals should still have the same behaviour on Parsec for future new versions.

This can only be checked via testing/code review. We can also add warnings in the code, move the relevent files in different modules.

Testing

For testing, those signals should be exerced for different versions of Parsec.

@hug-dev hug-dev added the stability Issues related to the stability of the service label Apr 14, 2021
@hug-dev
Copy link
Member Author

hug-dev commented Apr 21, 2021

All the existing signals should be tested and new tests should be created for the ones added.
Can also do the code separation thing as described in #392

@hug-dev hug-dev added this to the Parsec Release 0.8.0 milestone May 5, 2021
@hug-dev hug-dev self-assigned this Jun 18, 2021
@hug-dev
Copy link
Member Author

hug-dev commented Jun 18, 2021

Parsec responds to three signals:

  • SIGINT and SIGTERM: gracefully terminates it
  • SIGHUP: reload the configuration

Those signals are tested in the CI file. The whole main.rs file will be put under CODEOWNERS so that it covers both this issue and #396

@hug-dev hug-dev closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stability Issues related to the stability of the service
Projects
None yet
Development

No branches or pull requests

1 participant