Update psa_crypto and parsec-interface dependencies

Remove redundant comments
Fix index MAX_ID for key ID gen

Signed-off-by: Samuel Bailey <[email protected]>

Author: sbailey-arm

Cargo.toml

@@ -18,7 +18,7 @@ name = "parsec"
 path = "src/bin/main.rs"
 
 [dependencies]
-parsec-interface = { path = "../parsec-interface-rs" }
+parsec-interface = "0.16.0"
 rand = { version = "0.7.2", features = ["small_rng"] }
 base64 = "0.10.1"
 uuid = "0.7.4"
@@ -40,7 +40,7 @@ derivative = "2.1.1"
 version = "3.0.0"
 hex = "0.4.2"
 picky = "5.0.0"
-psa-crypto = { path = "../rust-psa-crypto/psa-crypto" , default-features = false, features = ["with-mbed-crypto"], optional = true }
+psa-crypto = { version = "0.2.0" , default-features = false, features = ["with-mbed-crypto"], optional = true }
 
 [dev-dependencies]
 ring = "0.16.12"

src/providers/mbed_provider/key_management.rs

@@ -50,10 +50,10 @@ fn create_key_id(
     local_ids_handle: &mut LocalIdStore,
 ) -> Result<key::psa_key_id_t> {
     let mut rng = SmallRng::from_entropy();
-    let mut key_id = rng.gen_range(key::PSA_KEY_ID_USER_MIN, key::PSA_KEY_ID_USER_MAX);
+    let mut key_id = rng.gen_range(key::PSA_KEY_ID_USER_MIN, key::PSA_KEY_ID_USER_MAX + 1);
 
     while local_ids_handle.contains(&key_id) {
-        key_id = rng.gen_range(key::PSA_KEY_ID_USER_MIN, key::PSA_KEY_ID_USER_MAX);
+        key_id = rng.gen_range(key::PSA_KEY_ID_USER_MIN, key::PSA_KEY_ID_USER_MAX + 1);
     }
     let key_info = KeyInfo {
         id: key_id.to_ne_bytes().to_vec(),
@@ -209,7 +209,6 @@ impl MbedProvider {
         let buffer_size = utils::psa_export_public_key_size(&key_attributes)?;
         let mut buffer = vec![0u8; buffer_size];
 
-        // Safety: same conditions than above.
         let export_length = psa_crypto_key_management::export_public(id, &mut buffer)?;
 
         buffer.resize(export_length, 0);

src/providers/mbed_provider/mod.rs

@@ -18,13 +18,6 @@ use std::sync::{Arc, Mutex, RwLock};
 use std_semaphore::Semaphore;
 use uuid::Uuid;
 
-#[allow(
-    non_snake_case,
-    non_camel_case_types,
-    non_upper_case_globals,
-    dead_code,
-    trivial_casts
-)]
 mod asym_sign;
 #[allow(dead_code)]
 mod key_management;
@@ -109,9 +102,6 @@ impl MbedProvider {
                             }
                         };
 
-                        // Safety: safe because:
-                        // * the Mbed Crypto library has been initialized
-                        // * this code is executed only by the main thread
                         let pc_key_id = key::Id::from_persistent_key_id(key_id);
                         match key::Attributes::from_key_id(pc_key_id) {
                             Ok(_) => {