Merge pull request #92 from ionut-arm/lint-travis

Fix lints and remove Travis build

Author: ionut-arm

.travis.yml renamed to .travis.yml.disabled

@@ -100,12 +100,13 @@ mod test {
     #[test]
     fn proto_to_resp() {
         let mut proto: ResultProto = Default::default();
-        let mut authenticator_info = AuthenticatorInfoProto::default();
-        authenticator_info.description = String::from("authenticator description");
-        authenticator_info.version_maj = 0;
-        authenticator_info.version_min = 1;
-        authenticator_info.version_rev = 0;
-        authenticator_info.id = AuthType::Direct as u32;
+        let authenticator_info = AuthenticatorInfoProto {
+            description: String::from("authenticator description"),
+            version_maj: 0,
+            version_min: 1,
+            version_rev: 0,
+            id: AuthType::Direct as u32,
+        };
         proto.authenticators.push(authenticator_info);
         let resp: Result = proto.try_into().unwrap();
 

src/operations_protobuf/convert_list_authenticators.rs

@@ -106,9 +106,6 @@ mod test {
     #[test]
     fn proto_to_resp() {
         let mut proto: ResultProto = Default::default();
-        let mut key_info = KeyInfoProto::default();
-        key_info.provider_id = ProviderID::MbedCrypto as u32;
-        key_info.name = String::from("Some Key Name");
 
         let key_attrs = Attributes {
             lifetime: Lifetime::Persistent,
@@ -136,7 +133,11 @@ mod test {
         };
 
         let key_attrs_proto: KeyAttributesProto = key_attrs.try_into().unwrap();
-        key_info.attributes = Some(key_attrs_proto);
+        let key_info = KeyInfoProto {
+            provider_id: ProviderID::MbedCrypto as u32,
+            name: String::from("Some Key Name"),
+            attributes: Some(key_attrs_proto),
+        };
         proto.keys.push(key_info);
 
         let resp: Result = proto.try_into().unwrap();

src/operations_protobuf/convert_list_keys.rs

@@ -112,14 +112,15 @@ mod test {
     #[test]
     fn proto_to_resp() {
         let mut proto: ResultProto = Default::default();
-        let mut provider_info = ProviderInfoProto::default();
-        provider_info.uuid = String::from("9840cd61-9367-4010-bc24-f5b98a6174d1");
-        provider_info.description = String::from("provider description");
-        provider_info.vendor = String::from("Arm");
-        provider_info.version_maj = 0;
-        provider_info.version_min = 1;
-        provider_info.version_rev = 0;
-        provider_info.id = 1;
+        let provider_info = ProviderInfoProto {
+            uuid: String::from("9840cd61-9367-4010-bc24-f5b98a6174d1"),
+            description: String::from("provider description"),
+            vendor: String::from("Arm"),
+            version_maj: 0,
+            version_min: 1,
+            version_rev: 0,
+            id: 1,
+        };
         proto.providers.push(provider_info);
         let resp: Result = proto.try_into().unwrap();
 

src/operations_protobuf/convert_list_providers.rs

@@ -25,9 +25,10 @@ impl TryFrom<Result> for ResultProto {
     type Error = ResponseStatus;
 
     fn try_from(result: Result) -> std::result::Result<Self, Self::Error> {
-        let mut proto_response: ResultProto = Default::default();
-        proto_response.wire_protocol_version_maj = u32::from(result.wire_protocol_version_maj);
-        proto_response.wire_protocol_version_min = u32::from(result.wire_protocol_version_min);
+        let proto_response = ResultProto {
+            wire_protocol_version_maj: u32::from(result.wire_protocol_version_maj),
+            wire_protocol_version_min: u32::from(result.wire_protocol_version_min),
+        };
 
         Ok(proto_response)
     }
@@ -58,9 +59,10 @@ mod test {
 
     #[test]
     fn proto_to_resp() {
-        let mut proto: ResultProto = Default::default();
-        proto.wire_protocol_version_maj = 1;
-        proto.wire_protocol_version_min = 1;
+        let proto = ResultProto {
+            wire_protocol_version_maj: 1,
+            wire_protocol_version_min: 1,
+        };
         let resp: Result = proto.try_into().unwrap();
 
         assert!(resp.wire_protocol_version_maj == 1);

src/operations_protobuf/convert_ping.rs

@@ -27,9 +27,10 @@ impl TryFrom<Operation> for OperationProto {
     type Error = ResponseStatus;
 
     fn try_from(op: Operation) -> std::result::Result<Self, Self::Error> {
-        let mut proto: OperationProto = Default::default();
-        proto.key_name = op.key_name;
-        proto.attributes = Some(op.attributes.try_into()?);
+        let proto = OperationProto {
+            key_name: op.key_name,
+            attributes: Some(op.attributes.try_into()?),
+        };
 
         Ok(proto)
     }

src/operations_protobuf/convert_psa_generate_key.rs

@@ -21,8 +21,9 @@ impl TryFrom<Operation> for OperationProto {
     type Error = ResponseStatus;
 
     fn try_from(op: Operation) -> std::result::Result<Self, Self::Error> {
-        let mut proto: OperationProto = Default::default();
-        proto.size = op.size.try_into()?;
+        let proto = OperationProto {
+            size: op.size.try_into()?,
+        };
         Ok(proto)
     }
 }
@@ -60,8 +61,9 @@ mod test {
 
     #[test]
     fn proto_to_resp() {
-        let mut proto: ResultProto = Default::default();
-        proto.random_bytes = vec![0xDE, 0xAD, 0xBE, 0xEF];
+        let proto = ResultProto {
+            random_bytes: vec![0xDE, 0xAD, 0xBE, 0xEF],
+        };
 
         let resp: Result = proto.try_into().unwrap();