Skip to content

Fix types of output func #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2021
Merged

Fix types of output func #3119

merged 2 commits into from
Mar 29, 2021

Conversation

@kitadakyou
Copy link
Contributor

@kitadakyou kitadakyou commented Mar 19, 2021

Fixed #3115

@kitadakyou kitadakyou mentioned this pull request Mar 19, 2021
Closed
HackbrettXXX
HackbrettXXX requested changes Mar 22, 2021
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)

types/index.d.ts Outdated
Comment on lines 784 to 788
type: "pdfobjectnewwindow" | "pdfjsnewwindow"
): Window;
output(
type: "dataurlnewwindow",
options?: { filename?: string }
Copy link
Collaborator

@HackbrettXXX HackbrettXXX Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pdfobjectnewwindow and pdfjsnewwindow also accept the options object.

Copy link
Contributor Author

@kitadakyou kitadakyou Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HackbrettXXX
Thanks!
I fixed the options object.

HackbrettXXX
HackbrettXXX approved these changes Mar 29, 2021
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I'll merge it.

@HackbrettXXX HackbrettXXX merged commit e988a04 into parallax:master Mar 29, 2021
sthagen added a commit to sthagen/parallax-jsPDF that referenced this pull request Mar 29, 2021
@sthagen
Merge pull request #6 from MrRio/master
b59aac9 
Fix types of output func (parallax#3119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HackbrettXXX HackbrettXXX HackbrettXXX approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong typescript config on output with dataurlnewwindow

2 participants

@kitadakyou @HackbrettXXX