timeout the paren searching #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the search pair function almost stalls my decently powerful macbook pro on really long lines, could be annoying because of minification etc.this function just makes it backwards compatible in old vim versions or builds without this feature
| @@ -59,6 +59,14 @@ let s:syng_linecom = 'linecomment\c' | |||
| " Expression used to check whether we should skip a match with searchpair(). | |||
| let s:skip_expr = "synIDattr(synID(line('.'),col('.'),1),'name') =~ '".s:syng_strcom."'" | |||
|
|
|||
| func s:searchpar(start,mid,end,flags,stop) | |||
There was a problem hiding this comment.
This name is confusingly similar to searchpair. Perhaps s:searchparens would be clearer.
|
I look forward to this change. 👍 |
|
yes, I agree on the name |
|
haha, just tried a skip_expr which instead match the paren syntax items instead of Not being a comment/string/regex. sadly it's just as slow |
amadeus
pushed a commit
that referenced
this pull request
Jun 14, 2016
the search pair function almost stalls my decently powerful macbook pro on really long lines, could be annoying because of minification etc.this function just makes it backwards compatible in old vim versions or builds without this feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the search pair function almost stalls my decently powerful macbook pro on really long lines, could be annoying because of minification etc.this function just makes it backwards compatible in old vim versions or builds without this feature.it is set to 300ms, though i am open to suggestions