Skip to content

Flow type value missing semi-colon terminator #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gf3 opened this issue Jun 28, 2016 · 3 comments
Closed

Flow type value missing semi-colon terminator #517

gf3 opened this issue Jun 28, 2016 · 3 comments

Comments

@gf3
Copy link
Contributor

gf3 commented Jun 28, 2016

Example snippet:

type State = {
  errorMessages: Array<string>;
  forceValidation: bool;
  invalidFields: Array<string>;
  submitting: bool;
};


//-----------------------------------------------------------------------------
// Blah blah
//-----------------------------------------------------------------------------

function lol() {
   // ...
}

can fix by changing:

syntax region  jsFlowTypeValue      contained matchgroup=jsFlowNoise start=/:/       end=/[,}]/ contains=@jsFlowCluster

to

syntax region  jsFlowTypeValue      contained matchgroup=jsFlowNoise start=/:/       end=/[,};]/ contains=@jsFlowCluster
@gf3 gf3 mentioned this issue Jun 28, 2016
@amadeus
Copy link
Collaborator

amadeus commented Jun 28, 2016

#518 should fix this problem. But that branch also includes some bigger fixes as well, so it would be helpful for you to test that branch and see if I didn't cause any other inadvertent issues.

@gf3
Copy link
Contributor Author

gf3 commented Jun 28, 2016

tested and fixed in #518

@amadeus
Copy link
Collaborator

amadeus commented Jun 28, 2016

Fixed in develop

@amadeus amadeus closed this as completed Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants