From 403fe4e9727ce3a19cca9fe2f46f5817488baafb Mon Sep 17 00:00:00 2001 From: Brock Date: Mon, 21 Nov 2022 09:57:13 -0800 Subject: [PATCH 01/11] TST: troubleshoot strict=False xfails --- pandas/tests/base/test_unique.py | 2 +- pandas/tests/computation/test_eval.py | 2 +- pandas/tests/extension/json/test_json.py | 1 - pandas/tests/frame/test_constructors.py | 1 - pandas/tests/indexes/test_common.py | 4 +--- pandas/tests/indexes/test_setops.py | 4 +--- pandas/tests/io/parser/test_network.py | 7 ------- pandas/tests/plotting/frame/test_frame.py | 1 - pandas/tests/scalar/timedelta/test_timedelta.py | 1 - pandas/tests/scalar/timestamp/test_unary_ops.py | 1 - pandas/tests/tools/test_to_datetime.py | 3 --- pandas/tests/tools/test_to_time.py | 1 - 12 files changed, 4 insertions(+), 24 deletions(-) diff --git a/pandas/tests/base/test_unique.py b/pandas/tests/base/test_unique.py index 66cc000b9f458..0b447597cf34f 100644 --- a/pandas/tests/base/test_unique.py +++ b/pandas/tests/base/test_unique.py @@ -106,7 +106,7 @@ def test_nunique_null(null_obj, index_or_series_obj): @pytest.mark.single_cpu @pytest.mark.xfail( - reason="Flaky in the CI. Remove once CI has a single build: GH 44584", strict=False + reason="Flaky in the CI. Remove once CI has a single build: GH 44584" ) def test_unique_bad_unicode(index_or_series): # regression test for #34550 diff --git a/pandas/tests/computation/test_eval.py b/pandas/tests/computation/test_eval.py index b0a182ffe4933..97d4f057472f5 100644 --- a/pandas/tests/computation/test_eval.py +++ b/pandas/tests/computation/test_eval.py @@ -872,7 +872,7 @@ def test_basic_series_frame_alignment( f"parser={parser}, index_name={index_name}, " f"r_idx_type={r_idx_type}, c_idx_type={c_idx_type}" ) - request.node.add_marker(pytest.mark.xfail(reason=reason, strict=False)) + request.node.add_marker(pytest.mark.xfail(reason=reason)) df = tm.makeCustomDataframe( 10, 7, data_gen_f=f, r_idx_type=r_idx_type, c_idx_type=c_idx_type ) diff --git a/pandas/tests/extension/json/test_json.py b/pandas/tests/extension/json/test_json.py index b8df787b7214a..d6ae399e19fa4 100644 --- a/pandas/tests/extension/json/test_json.py +++ b/pandas/tests/extension/json/test_json.py @@ -276,7 +276,6 @@ def test_combine_add(self, data_repeated): @pytest.mark.xfail( reason="combine for JSONArray not supported - " "may pass depending on random data", - strict=False, ) def test_combine_first(self, data): super().test_combine_first(data) diff --git a/pandas/tests/frame/test_constructors.py b/pandas/tests/frame/test_constructors.py index b6c6792355fc7..55d4519fc5376 100644 --- a/pandas/tests/frame/test_constructors.py +++ b/pandas/tests/frame/test_constructors.py @@ -3141,7 +3141,6 @@ def test_frame_allow_non_nano(self, arr): @pytest.mark.xfail( # TODO(2.0): xfail should become unnecessary - strict=False, reason="stack_arrays converts TDA to ndarray, then goes " "through ensure_wrapped_if_datetimelike", ) diff --git a/pandas/tests/indexes/test_common.py b/pandas/tests/indexes/test_common.py index 834be77cbdcda..28b5f92c8c8b9 100644 --- a/pandas/tests/indexes/test_common.py +++ b/pandas/tests/indexes/test_common.py @@ -471,9 +471,7 @@ def test_sort_values_with_missing(index_with_missing, na_position, request): if isinstance(index_with_missing, CategoricalIndex): request.node.add_marker( - pytest.mark.xfail( - reason="missing value sorting order not well-defined", strict=False - ) + pytest.mark.xfail(reason="missing value sorting order not well-defined") ) missing_count = np.sum(index_with_missing.isna()) diff --git a/pandas/tests/indexes/test_setops.py b/pandas/tests/indexes/test_setops.py index 14cde141d1c60..5777305ed1276 100644 --- a/pandas/tests/indexes/test_setops.py +++ b/pandas/tests/indexes/test_setops.py @@ -77,9 +77,7 @@ def test_union_different_types(index_flat, index_flat2, request): # [True, True, True, True, True, True, True, True, False, False], dtype='bool' # ) # idx2 = Int64Index([0, 0, 1, 1, 2, 2], dtype='int64') - mark = pytest.mark.xfail( - reason="GH#44000 True==1", raises=ValueError, strict=False - ) + mark = pytest.mark.xfail(reason="GH#44000 True==1", raises=ValueError) request.node.add_marker(mark) common_dtype = find_common_type([idx1.dtype, idx2.dtype]) diff --git a/pandas/tests/io/parser/test_network.py b/pandas/tests/io/parser/test_network.py index 0b16d1d9ec6b0..d323bfb61f454 100644 --- a/pandas/tests/io/parser/test_network.py +++ b/pandas/tests/io/parser/test_network.py @@ -80,11 +80,6 @@ def tips_df(datapath): @pytest.mark.single_cpu @pytest.mark.usefixtures("s3_resource") -@pytest.mark.xfail( - reason="CI race condition GH 45433, GH 44584", - raises=FileNotFoundError, - strict=False, -) @td.skip_if_not_us_locale() class TestS3: @td.skip_if_no("s3fs") @@ -226,7 +221,6 @@ def test_read_s3_fails(self, s3so): with pytest.raises(OSError, match=msg): read_csv("s3://cant_get_it/file.csv") - @pytest.mark.xfail(reason="GH#39155 s3fs upgrade", strict=False) def test_write_s3_csv_fails(self, tips_df, s3so): # GH 32486 # Attempting to write to an invalid S3 path should raise @@ -242,7 +236,6 @@ def test_write_s3_csv_fails(self, tips_df, s3so): "s3://an_s3_bucket_data_doesnt_exit/not_real.csv", storage_options=s3so ) - @pytest.mark.xfail(reason="GH#39155 s3fs upgrade", strict=False) @td.skip_if_no("pyarrow") def test_write_s3_parquet_fails(self, tips_df, s3so): # GH 27679 diff --git a/pandas/tests/plotting/frame/test_frame.py b/pandas/tests/plotting/frame/test_frame.py index 06f9ffd2bb23a..6f5ff16bbd7d8 100644 --- a/pandas/tests/plotting/frame/test_frame.py +++ b/pandas/tests/plotting/frame/test_frame.py @@ -474,7 +474,6 @@ def test_line_lim(self): assert xmax >= lines[0].get_data()[0][-1] @pytest.mark.xfail( - strict=False, reason="2020-12-01 this has been failing periodically on the " "ymin==0 assertion for a week or so.", ) diff --git a/pandas/tests/scalar/timedelta/test_timedelta.py b/pandas/tests/scalar/timedelta/test_timedelta.py index 924f756edb233..0cd3cc1f9504d 100644 --- a/pandas/tests/scalar/timedelta/test_timedelta.py +++ b/pandas/tests/scalar/timedelta/test_timedelta.py @@ -711,7 +711,6 @@ def test_round_implementation_bounds(self): with pytest.raises(OverflowError, match=msg): Timedelta.max.ceil("s") - @pytest.mark.xfail(reason="Failing on builds", strict=False) @given(val=st.integers(min_value=iNaT + 1, max_value=lib.i8max)) @pytest.mark.parametrize( "method", [Timedelta.round, Timedelta.floor, Timedelta.ceil] diff --git a/pandas/tests/scalar/timestamp/test_unary_ops.py b/pandas/tests/scalar/timestamp/test_unary_ops.py index 1c1f3acc8331f..297a14a5d97da 100644 --- a/pandas/tests/scalar/timestamp/test_unary_ops.py +++ b/pandas/tests/scalar/timestamp/test_unary_ops.py @@ -297,7 +297,6 @@ def test_round_implementation_bounds(self): with pytest.raises(OverflowError, match=msg): Timestamp.max.ceil("s") - @pytest.mark.xfail(reason="Failing on builds", strict=False) @given(val=st.integers(iNaT + 1, lib.i8max)) @pytest.mark.parametrize( "method", [Timestamp.round, Timestamp.floor, Timestamp.ceil] diff --git a/pandas/tests/tools/test_to_datetime.py b/pandas/tests/tools/test_to_datetime.py index 4c70aeb3e36aa..d7eabe1b14bb2 100644 --- a/pandas/tests/tools/test_to_datetime.py +++ b/pandas/tests/tools/test_to_datetime.py @@ -293,7 +293,6 @@ def test_to_datetime_format_microsecond(self, cache): marks=pytest.mark.xfail( locale.getlocale()[0] in ("zh_CN", "it_IT"), reason="fail on a CI build with LC_ALL=zh_CN.utf8/it_IT.utf8", - strict=False, ), ), pytest.param( @@ -303,7 +302,6 @@ def test_to_datetime_format_microsecond(self, cache): marks=pytest.mark.xfail( locale.getlocale()[0] in ("zh_CN", "it_IT"), reason="fail on a CI build with LC_ALL=zh_CN.utf8/it_IT.utf8", - strict=False, ), ), pytest.param( @@ -313,7 +311,6 @@ def test_to_datetime_format_microsecond(self, cache): marks=pytest.mark.xfail( locale.getlocale()[0] in ("zh_CN", "it_IT"), reason="fail on a CI build with LC_ALL=zh_CN.utf8/it_IT.utf8", - strict=False, ), ), ], diff --git a/pandas/tests/tools/test_to_time.py b/pandas/tests/tools/test_to_time.py index 5046fd9d0edc1..e883b4916ac90 100644 --- a/pandas/tests/tools/test_to_time.py +++ b/pandas/tests/tools/test_to_time.py @@ -15,7 +15,6 @@ fails_on_non_english = pytest.mark.xfail( locale.getlocale()[0] in ("zh_CN", "it_IT"), reason="fail on a CI build with LC_ALL=zh_CN.utf8/it_IT.utf8", - strict=False, ) From e7f0bd942fe2ad2cfbb5ac7083651edf96f0b0c2 Mon Sep 17 00:00:00 2001 From: Brock Date: Mon, 21 Nov 2022 13:14:07 -0800 Subject: [PATCH 02/11] restore some --- pandas/tests/frame/test_constructors.py | 5 ----- pandas/tests/indexes/test_common.py | 4 +++- pandas/tests/indexes/test_setops.py | 4 +++- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/pandas/tests/frame/test_constructors.py b/pandas/tests/frame/test_constructors.py index 55d4519fc5376..29066c29a03ee 100644 --- a/pandas/tests/frame/test_constructors.py +++ b/pandas/tests/frame/test_constructors.py @@ -3139,11 +3139,6 @@ def test_frame_allow_non_nano(self, arr): df = DataFrame(arr) assert df.dtypes[0] == arr.dtype - @pytest.mark.xfail( - # TODO(2.0): xfail should become unnecessary - reason="stack_arrays converts TDA to ndarray, then goes " - "through ensure_wrapped_if_datetimelike", - ) def test_frame_from_dict_allow_non_nano(self, arr): df = DataFrame({0: arr}) assert df.dtypes[0] == arr.dtype diff --git a/pandas/tests/indexes/test_common.py b/pandas/tests/indexes/test_common.py index 28b5f92c8c8b9..834be77cbdcda 100644 --- a/pandas/tests/indexes/test_common.py +++ b/pandas/tests/indexes/test_common.py @@ -471,7 +471,9 @@ def test_sort_values_with_missing(index_with_missing, na_position, request): if isinstance(index_with_missing, CategoricalIndex): request.node.add_marker( - pytest.mark.xfail(reason="missing value sorting order not well-defined") + pytest.mark.xfail( + reason="missing value sorting order not well-defined", strict=False + ) ) missing_count = np.sum(index_with_missing.isna()) diff --git a/pandas/tests/indexes/test_setops.py b/pandas/tests/indexes/test_setops.py index 5777305ed1276..14cde141d1c60 100644 --- a/pandas/tests/indexes/test_setops.py +++ b/pandas/tests/indexes/test_setops.py @@ -77,7 +77,9 @@ def test_union_different_types(index_flat, index_flat2, request): # [True, True, True, True, True, True, True, True, False, False], dtype='bool' # ) # idx2 = Int64Index([0, 0, 1, 1, 2, 2], dtype='int64') - mark = pytest.mark.xfail(reason="GH#44000 True==1", raises=ValueError) + mark = pytest.mark.xfail( + reason="GH#44000 True==1", raises=ValueError, strict=False + ) request.node.add_marker(mark) common_dtype = find_common_type([idx1.dtype, idx2.dtype]) From b15376e196f752e9ec4eb1e348827ab76c81107b Mon Sep 17 00:00:00 2001 From: Brock Date: Mon, 21 Nov 2022 15:13:16 -0800 Subject: [PATCH 03/11] revert --- pandas/tests/scalar/timedelta/test_timedelta.py | 1 + pandas/tests/scalar/timestamp/test_unary_ops.py | 1 + 2 files changed, 2 insertions(+) diff --git a/pandas/tests/scalar/timedelta/test_timedelta.py b/pandas/tests/scalar/timedelta/test_timedelta.py index 0cd3cc1f9504d..924f756edb233 100644 --- a/pandas/tests/scalar/timedelta/test_timedelta.py +++ b/pandas/tests/scalar/timedelta/test_timedelta.py @@ -711,6 +711,7 @@ def test_round_implementation_bounds(self): with pytest.raises(OverflowError, match=msg): Timedelta.max.ceil("s") + @pytest.mark.xfail(reason="Failing on builds", strict=False) @given(val=st.integers(min_value=iNaT + 1, max_value=lib.i8max)) @pytest.mark.parametrize( "method", [Timedelta.round, Timedelta.floor, Timedelta.ceil] diff --git a/pandas/tests/scalar/timestamp/test_unary_ops.py b/pandas/tests/scalar/timestamp/test_unary_ops.py index 297a14a5d97da..1c1f3acc8331f 100644 --- a/pandas/tests/scalar/timestamp/test_unary_ops.py +++ b/pandas/tests/scalar/timestamp/test_unary_ops.py @@ -297,6 +297,7 @@ def test_round_implementation_bounds(self): with pytest.raises(OverflowError, match=msg): Timestamp.max.ceil("s") + @pytest.mark.xfail(reason="Failing on builds", strict=False) @given(val=st.integers(iNaT + 1, lib.i8max)) @pytest.mark.parametrize( "method", [Timestamp.round, Timestamp.floor, Timestamp.ceil] From 50a3d56da97f5322ea79788d8c9199b757fc74dc Mon Sep 17 00:00:00 2001 From: Brock Date: Mon, 21 Nov 2022 15:14:41 -0800 Subject: [PATCH 04/11] remove xfail --- pandas/tests/computation/test_eval.py | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/pandas/tests/computation/test_eval.py b/pandas/tests/computation/test_eval.py index 97d4f057472f5..571bf92870ab7 100644 --- a/pandas/tests/computation/test_eval.py +++ b/pandas/tests/computation/test_eval.py @@ -860,19 +860,6 @@ def test_basic_frame_series_alignment( def test_basic_series_frame_alignment( self, request, engine, parser, index_name, r_idx_type, c_idx_type ): - if ( - engine == "numexpr" - and parser == "pandas" - and index_name == "index" - and r_idx_type == "i" - and c_idx_type == "s" - ): - reason = ( - f"Flaky column ordering when engine={engine}, " - f"parser={parser}, index_name={index_name}, " - f"r_idx_type={r_idx_type}, c_idx_type={c_idx_type}" - ) - request.node.add_marker(pytest.mark.xfail(reason=reason)) df = tm.makeCustomDataframe( 10, 7, data_gen_f=f, r_idx_type=r_idx_type, c_idx_type=c_idx_type ) From e10b5ffdac689576f6f97cdc773595ed93b1f067 Mon Sep 17 00:00:00 2001 From: Brock Date: Mon, 21 Nov 2022 19:04:37 -0800 Subject: [PATCH 05/11] remove xfail --- pandas/tests/plotting/frame/test_frame.py | 4 ---- pandas/tests/tools/test_to_time.py | 1 + 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/pandas/tests/plotting/frame/test_frame.py b/pandas/tests/plotting/frame/test_frame.py index 6f5ff16bbd7d8..6422834e21c6b 100644 --- a/pandas/tests/plotting/frame/test_frame.py +++ b/pandas/tests/plotting/frame/test_frame.py @@ -473,10 +473,6 @@ def test_line_lim(self): assert xmin <= lines[0].get_data()[0][0] assert xmax >= lines[0].get_data()[0][-1] - @pytest.mark.xfail( - reason="2020-12-01 this has been failing periodically on the " - "ymin==0 assertion for a week or so.", - ) @pytest.mark.parametrize("stacked", [True, False]) def test_area_lim(self, stacked): df = DataFrame(np.random.rand(6, 4), columns=["x", "y", "z", "four"]) diff --git a/pandas/tests/tools/test_to_time.py b/pandas/tests/tools/test_to_time.py index e883b4916ac90..5046fd9d0edc1 100644 --- a/pandas/tests/tools/test_to_time.py +++ b/pandas/tests/tools/test_to_time.py @@ -15,6 +15,7 @@ fails_on_non_english = pytest.mark.xfail( locale.getlocale()[0] in ("zh_CN", "it_IT"), reason="fail on a CI build with LC_ALL=zh_CN.utf8/it_IT.utf8", + strict=False, ) From bd6e426baa4bc0b08122e5ba807f7a23690a7ee6 Mon Sep 17 00:00:00 2001 From: Brock Date: Tue, 22 Nov 2022 12:25:53 -0800 Subject: [PATCH 06/11] restore test_area_lim, tighten a little bit --- pandas/tests/plotting/frame/test_frame.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pandas/tests/plotting/frame/test_frame.py b/pandas/tests/plotting/frame/test_frame.py index 6422834e21c6b..860dce82c9325 100644 --- a/pandas/tests/plotting/frame/test_frame.py +++ b/pandas/tests/plotting/frame/test_frame.py @@ -11,6 +11,7 @@ import numpy as np import pytest +from pandas.compat import is_platform_windows import pandas.util._test_decorators as td from pandas.core.dtypes.api import is_list_like @@ -473,6 +474,12 @@ def test_line_lim(self): assert xmin <= lines[0].get_data()[0][0] assert xmax >= lines[0].get_data()[0][-1] + @pytest.mark.xfail( + not is_platform_windows(), + strict=False, + reason="2020-12-01 this has been failing periodically on the " + "ymin==0 assertion for a week or so.", + ) @pytest.mark.parametrize("stacked", [True, False]) def test_area_lim(self, stacked): df = DataFrame(np.random.rand(6, 4), columns=["x", "y", "z", "four"]) From 42a20a7355b06f6f1fe0d02f72d0485c74abd38f Mon Sep 17 00:00:00 2001 From: Brock Date: Tue, 22 Nov 2022 12:27:18 -0800 Subject: [PATCH 07/11] revert --- pandas/tests/tools/test_to_datetime.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pandas/tests/tools/test_to_datetime.py b/pandas/tests/tools/test_to_datetime.py index d7eabe1b14bb2..4c70aeb3e36aa 100644 --- a/pandas/tests/tools/test_to_datetime.py +++ b/pandas/tests/tools/test_to_datetime.py @@ -293,6 +293,7 @@ def test_to_datetime_format_microsecond(self, cache): marks=pytest.mark.xfail( locale.getlocale()[0] in ("zh_CN", "it_IT"), reason="fail on a CI build with LC_ALL=zh_CN.utf8/it_IT.utf8", + strict=False, ), ), pytest.param( @@ -302,6 +303,7 @@ def test_to_datetime_format_microsecond(self, cache): marks=pytest.mark.xfail( locale.getlocale()[0] in ("zh_CN", "it_IT"), reason="fail on a CI build with LC_ALL=zh_CN.utf8/it_IT.utf8", + strict=False, ), ), pytest.param( @@ -311,6 +313,7 @@ def test_to_datetime_format_microsecond(self, cache): marks=pytest.mark.xfail( locale.getlocale()[0] in ("zh_CN", "it_IT"), reason="fail on a CI build with LC_ALL=zh_CN.utf8/it_IT.utf8", + strict=False, ), ), ], From a008f8224cac454e7ad6d9f81ed93f7f16cb8877 Mon Sep 17 00:00:00 2001 From: Brock Date: Tue, 22 Nov 2022 12:27:54 -0800 Subject: [PATCH 08/11] remove xfail --- pandas/tests/base/test_unique.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/pandas/tests/base/test_unique.py b/pandas/tests/base/test_unique.py index 0b447597cf34f..b1b0479f397b1 100644 --- a/pandas/tests/base/test_unique.py +++ b/pandas/tests/base/test_unique.py @@ -105,9 +105,6 @@ def test_nunique_null(null_obj, index_or_series_obj): @pytest.mark.single_cpu -@pytest.mark.xfail( - reason="Flaky in the CI. Remove once CI has a single build: GH 44584" -) def test_unique_bad_unicode(index_or_series): # regression test for #34550 uval = "\ud83d" # smiley emoji From b0b69bf70495b32875314184444d5ea564a30a87 Mon Sep 17 00:00:00 2001 From: Brock Date: Tue, 22 Nov 2022 14:42:21 -0800 Subject: [PATCH 09/11] revert --- pandas/tests/io/parser/test_network.py | 7 +++++++ pandas/tests/plotting/frame/test_frame.py | 2 -- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/pandas/tests/io/parser/test_network.py b/pandas/tests/io/parser/test_network.py index d323bfb61f454..0b16d1d9ec6b0 100644 --- a/pandas/tests/io/parser/test_network.py +++ b/pandas/tests/io/parser/test_network.py @@ -80,6 +80,11 @@ def tips_df(datapath): @pytest.mark.single_cpu @pytest.mark.usefixtures("s3_resource") +@pytest.mark.xfail( + reason="CI race condition GH 45433, GH 44584", + raises=FileNotFoundError, + strict=False, +) @td.skip_if_not_us_locale() class TestS3: @td.skip_if_no("s3fs") @@ -221,6 +226,7 @@ def test_read_s3_fails(self, s3so): with pytest.raises(OSError, match=msg): read_csv("s3://cant_get_it/file.csv") + @pytest.mark.xfail(reason="GH#39155 s3fs upgrade", strict=False) def test_write_s3_csv_fails(self, tips_df, s3so): # GH 32486 # Attempting to write to an invalid S3 path should raise @@ -236,6 +242,7 @@ def test_write_s3_csv_fails(self, tips_df, s3so): "s3://an_s3_bucket_data_doesnt_exit/not_real.csv", storage_options=s3so ) + @pytest.mark.xfail(reason="GH#39155 s3fs upgrade", strict=False) @td.skip_if_no("pyarrow") def test_write_s3_parquet_fails(self, tips_df, s3so): # GH 27679 diff --git a/pandas/tests/plotting/frame/test_frame.py b/pandas/tests/plotting/frame/test_frame.py index 860dce82c9325..06f9ffd2bb23a 100644 --- a/pandas/tests/plotting/frame/test_frame.py +++ b/pandas/tests/plotting/frame/test_frame.py @@ -11,7 +11,6 @@ import numpy as np import pytest -from pandas.compat import is_platform_windows import pandas.util._test_decorators as td from pandas.core.dtypes.api import is_list_like @@ -475,7 +474,6 @@ def test_line_lim(self): assert xmax >= lines[0].get_data()[0][-1] @pytest.mark.xfail( - not is_platform_windows(), strict=False, reason="2020-12-01 this has been failing periodically on the " "ymin==0 assertion for a week or so.", From c4a64aa3f6dcb0500d623d4a9527f40d917875a5 Mon Sep 17 00:00:00 2001 From: Brock Date: Fri, 2 Dec 2022 16:28:39 -0800 Subject: [PATCH 10/11] re-strict --- pandas/tests/extension/json/test_json.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pandas/tests/extension/json/test_json.py b/pandas/tests/extension/json/test_json.py index d6ae399e19fa4..b8df787b7214a 100644 --- a/pandas/tests/extension/json/test_json.py +++ b/pandas/tests/extension/json/test_json.py @@ -276,6 +276,7 @@ def test_combine_add(self, data_repeated): @pytest.mark.xfail( reason="combine for JSONArray not supported - " "may pass depending on random data", + strict=False, ) def test_combine_first(self, data): super().test_combine_first(data) From f60f2cd1189ee46d0cf737f84e479d24a0b43340 Mon Sep 17 00:00:00 2001 From: Brock Date: Fri, 2 Dec 2022 16:34:38 -0800 Subject: [PATCH 11/11] more specific --- pandas/tests/extension/json/test_json.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pandas/tests/extension/json/test_json.py b/pandas/tests/extension/json/test_json.py index b8df787b7214a..e6012a04dfc7a 100644 --- a/pandas/tests/extension/json/test_json.py +++ b/pandas/tests/extension/json/test_json.py @@ -277,6 +277,7 @@ def test_combine_add(self, data_repeated): reason="combine for JSONArray not supported - " "may pass depending on random data", strict=False, + raises=AssertionError, ) def test_combine_first(self, data): super().test_combine_first(data)