From f08d9ca9cd1840e4c75f53f61194cdb7d6d9c65a Mon Sep 17 00:00:00 2001 From: Richard Shadrach Date: Sat, 11 Jun 2022 09:46:43 -0400 Subject: [PATCH 1/4] CI: Debug CI ImportError --- .github/workflows/code-checks.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index 96088547634c5..8e7594240f999 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -65,6 +65,14 @@ jobs: id: build uses: ./.github/actions/build_pandas + - name: List symbols in np_datetime + run: nm -gD pandas/_libs/tslibs/np_datetime.cpython-38-x86_64-linux-gnu.so + if: ${{ steps.build.outcome == 'success' }} + + - name: List symbols in timestamps + run: nm -gD pandas/_libs/tslibs/timestamps.cpython-38-x86_64-linux-gnu.so + if: ${{ steps.build.outcome == 'success' }} + - name: Check for no warnings when building single-page docs run: ci/code_checks.sh single-docs if: ${{ steps.build.outcome == 'success' }} From ffd43b01bb585d731679a24f040c32231dd99d8b Mon Sep 17 00:00:00 2001 From: Richard Shadrach Date: Sat, 11 Jun 2022 10:20:34 -0400 Subject: [PATCH 2/4] move after code_checks --- .github/workflows/code-checks.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index 8e7594240f999..34b063123f3e2 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -65,17 +65,15 @@ jobs: id: build uses: ./.github/actions/build_pandas + - name: Check for no warnings when building single-page docs + run: ci/code_checks.sh single-docs + if: ${{ steps.build.outcome == 'success' }} + - name: List symbols in np_datetime run: nm -gD pandas/_libs/tslibs/np_datetime.cpython-38-x86_64-linux-gnu.so - if: ${{ steps.build.outcome == 'success' }} - name: List symbols in timestamps run: nm -gD pandas/_libs/tslibs/timestamps.cpython-38-x86_64-linux-gnu.so - if: ${{ steps.build.outcome == 'success' }} - - - name: Check for no warnings when building single-page docs - run: ci/code_checks.sh single-docs - if: ${{ steps.build.outcome == 'success' }} - name: Run checks on imported code run: ci/code_checks.sh code From 4e8522bea4b7edee885e82a354da5082856483ea Mon Sep 17 00:00:00 2001 From: Richard Shadrach Date: Sat, 11 Jun 2022 10:59:15 -0400 Subject: [PATCH 3/4] add np_datetime.o --- .github/workflows/code-checks.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index 34b063123f3e2..8b912a812c2f3 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -69,10 +69,13 @@ jobs: run: ci/code_checks.sh single-docs if: ${{ steps.build.outcome == 'success' }} - - name: List symbols in np_datetime + - name: List symbols in np_datetime.o + run: objdump -t build/temp.linux-x86_64-cpython-38/pandas/_libs/tslibs/src/datetime/np_datetime.o + + - name: List symbols in np_datetime.so run: nm -gD pandas/_libs/tslibs/np_datetime.cpython-38-x86_64-linux-gnu.so - - name: List symbols in timestamps + - name: List symbols in timestamps.so run: nm -gD pandas/_libs/tslibs/timestamps.cpython-38-x86_64-linux-gnu.so - name: Run checks on imported code From 5ed5825f4698aa02be87335a35fb31cd30ac6144 Mon Sep 17 00:00:00 2001 From: Richard Shadrach Date: Sat, 11 Jun 2022 12:10:21 -0400 Subject: [PATCH 4/4] run in ASV Benchmarks too --- .github/workflows/code-checks.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index 8b912a812c2f3..d1736f33c0469 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -143,6 +143,15 @@ jobs: asv machine --yes asv run --quick --dry-run --strict --durations=30 --python=same + - name: List symbols in np_datetime.o + run: objdump -t build/temp.linux-x86_64-cpython-38/pandas/_libs/tslibs/src/datetime/np_datetime.o + + - name: List symbols in np_datetime.so + run: nm -gD pandas/_libs/tslibs/np_datetime.cpython-38-x86_64-linux-gnu.so + + - name: List symbols in timestamps.so + run: nm -gD pandas/_libs/tslibs/timestamps.cpython-38-x86_64-linux-gnu.so + build_docker_dev_environment: name: Build Docker Dev Environment runs-on: ubuntu-latest