Skip to content

BUG: styler.format options and validator tests #43341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 6, 2021
Merged

BUG: styler.format options and validator tests #43341

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
643d300
styler.format options and validator tests
attack68 Sep 1, 2021
d42fdac
add to tests
attack68 Sep 1, 2021
fe30ac7
CI: Revive Banklist Tests (#42889)
lithomas1 Sep 1, 2021
dbfdd6f
Merge remote-tracking branch 'upstream/master' into bug_formatting_op…
attack68 Sep 1, 2021
09e483b
Merge remote-tracking branch 'upstream/master' into bug_formatting_op…
attack68 Sep 1, 2021
4671ec7
Merge remote-tracking branch 'upstream/master' into bug_formatting_op…
attack68 Sep 1, 2021
37a9b33
test param
attack68 Sep 2, 2021
f089218
Merge remote-tracking branch 'upstream/master' into bug_formatting_op…
attack68 Sep 4, 2021
2b4e0e9
Merge branch 'master' into bug_formatting_options
attack68 Sep 5, 2021
d51ddb6
revert and fix
attack68 Sep 5, 2021
2fb4e2c
revert and fix
attack68 Sep 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pandas/core/config_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,12 @@ def register_converter_cb(key):
will not be used in Jupyter Notebook.
"""


def _is_formatter(x):
if not (x is None or callable(x) or isinstance(x, (dict, str))):
raise ValueError("Value must have type 'callable, dict, str' or None.")


with cf.config_prefix("styler"):
cf.register_option("sparse.index", True, styler_sparse_index_doc, validator=is_bool)

Expand Down Expand Up @@ -851,7 +857,7 @@ def register_converter_cb(key):
"format.formatter",
None,
styler_formatter,
validator=is_instance_factory([type(None), dict, callable, str]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm why doesn't this work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

x = '{:.2f}'

    def inner(x) -> None:
>       if not isinstance(x, _type):
E       TypeError: isinstance() arg 2 must be a type or tuple of types

x = <function <lambda> at 0x1251dd160>

    def inner(x) -> None:
>       if not isinstance(x, _type):
E       TypeError: isinstance() arg 2 must be a type or tuple of types

Also the signature of of the is_instance_factory struggles with callable:

>>> isinstance(lambda x: x, callable)
False
>>> isinstance(lambda x: x, type(callable))
False
>>> callable(lambda x: x)
True

Copy link
Contributor Author

@attack68 attack68 Sep 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fixed: callable != Callable !!!

validator=_is_formatter,
)

cf.register_option("html.mathjax", True, styler_mathjax, validator=is_bool)
17 changes: 17 additions & 0 deletions pandas/tests/io/formats/style/test_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,3 +305,20 @@ def test_precision_zero(df):
ctx = styler._translate(True, True)
assert ctx["body"][0][2]["display_value"] == "-1"
assert ctx["body"][1][2]["display_value"] == "-1"


def test_format_options_validator():
df = DataFrame([[9]])
with option_context("styler.format.formatter", lambda x: f"{x:.3f}"):
assert " 9.000 " in df.style.to_latex()
with option_context("styler.format.formatter", "{:.2f}"):
assert " 9.00 " in df.style.to_latex()
with option_context("styler.format.formatter", {0: "{:.1f}"}):
assert " 9.0 " in df.style.to_latex()
with option_context("styler.format.formatter", None):
assert " 9 " in df.style.to_latex()

msg = "Value must have type"
with pytest.raises(ValueError, match=msg):
with option_context("styler.format.formatter", ["bad", "type"]):
df.style.to_latex()