From b9e420b56d0ee589ea4a6a6595279b468c4ae42f Mon Sep 17 00:00:00 2001 From: Ariel Pillemer <63328798+pillemer@users.noreply.github.com> Date: Mon, 7 Dec 2020 10:06:42 +1100 Subject: [PATCH 1/2] rewrite dict as literal in tests/io/parser/test_index_col.py for issue # 38138 rewrite unnecessary dict call as a literal in pandas/tests/io/parser/test_index_col.py Please let me know if anything needs to be amended, changed or fixed. I'm new to contributing. --- pandas/tests/io/parser/test_index_col.py | 40 +++++++++++++----------- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/pandas/tests/io/parser/test_index_col.py b/pandas/tests/io/parser/test_index_col.py index 9c6cad4b41949..12c50d34f7b98 100644 --- a/pandas/tests/io/parser/test_index_col.py +++ b/pandas/tests/io/parser/test_index_col.py @@ -86,35 +86,39 @@ def test_infer_index_col(all_parsers): @pytest.mark.parametrize( "index_col,kwargs", [ - (None, dict(columns=["x", "y", "z"])), - (False, dict(columns=["x", "y", "z"])), - (0, dict(columns=["y", "z"], index=Index([], name="x"))), - (1, dict(columns=["x", "z"], index=Index([], name="y"))), - ("x", dict(columns=["y", "z"], index=Index([], name="x"))), - ("y", dict(columns=["x", "z"], index=Index([], name="y"))), + (None, {"columns": ["x", "y", "z"]}), + (False, {"columns": ["x", "y", "z"]}), + (0, {"columns": ["y", "z"], "index": Index([], name="x")}), + (1, {"columns": ["x", "z"], "index": Index([], name="y")}), + ("x", {"columns": ["y", "z"], "index": Index([], name="x")}), + ("y", {"columns": ["x", "z"], "index": Index([], name="y")}), ( [0, 1], - dict( - columns=["z"], index=MultiIndex.from_arrays([[]] * 2, names=["x", "y"]) - ), + { + "columns": ["z"], + "index": MultiIndex.from_arrays([[]] * 2, names=["x", "y"]) + }, ), ( ["x", "y"], - dict( - columns=["z"], index=MultiIndex.from_arrays([[]] * 2, names=["x", "y"]) - ), + { + "columns": ["z"], + "index": MultiIndex.from_arrays([[]] * 2, names=["x", "y"]) + }, ), ( [1, 0], - dict( - columns=["z"], index=MultiIndex.from_arrays([[]] * 2, names=["y", "x"]) - ), + { + "columns": ["z"], + "index": MultiIndex.from_arrays([[]] * 2, names=["y", "x"]) + }, ), ( ["y", "x"], - dict( - columns=["z"], index=MultiIndex.from_arrays([[]] * 2, names=["y", "x"]) - ), + { + "columns": ["z"], + "index": MultiIndex.from_arrays([[]] * 2, names=["y", "x"]) + }, ), ], ) From 92a9b247f49c55009f4bd8ac7bc3400f5420a992 Mon Sep 17 00:00:00 2001 From: Ariel Pillemer <63328798+pillemer@users.noreply.github.com> Date: Mon, 7 Dec 2020 15:33:18 +1100 Subject: [PATCH 2/2] Update test_index_col.py fixed linting error --- pandas/tests/io/parser/test_index_col.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pandas/tests/io/parser/test_index_col.py b/pandas/tests/io/parser/test_index_col.py index 12c50d34f7b98..d55814a0e9a2d 100644 --- a/pandas/tests/io/parser/test_index_col.py +++ b/pandas/tests/io/parser/test_index_col.py @@ -95,28 +95,28 @@ def test_infer_index_col(all_parsers): ( [0, 1], { - "columns": ["z"], + "columns": ["z"], "index": MultiIndex.from_arrays([[]] * 2, names=["x", "y"]) }, ), ( ["x", "y"], { - "columns": ["z"], + "columns": ["z"], "index": MultiIndex.from_arrays([[]] * 2, names=["x", "y"]) }, ), ( [1, 0], { - "columns": ["z"], + "columns": ["z"], "index": MultiIndex.from_arrays([[]] * 2, names=["y", "x"]) }, ), ( ["y", "x"], { - "columns": ["z"], + "columns": ["z"], "index": MultiIndex.from_arrays([[]] * 2, names=["y", "x"]) }, ),