CLN: disallow tuple in to_offset #34703
Merged
+27
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jun 10, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
lgtm, pls add a whatsnew note (CI busted as well)
…n-to_offset-tuple
…n-to_offset-tuple
jreback
requested changes
Jun 14, 2020
| assert len(idx) == 20 | ||
| assert idx[-1] == edate | ||
| assert idx.freq == "5D" | ||
| with pytest.raises(TypeError, match="pass as a string instead"): |
Contributor
There was a problem hiding this comment.
can you move this with the other error tests?
| assert len(i1) == len(i2) | ||
| assert (i1 == i2).all() | ||
| assert i1.freq == i2.freq | ||
| with pytest.raises(TypeError, match="pass as a string instead"): |
| i2 = Period("1982", freq=("Min", 1)) | ||
| assert i1 == i2 | ||
|
|
||
| with pytest.raises(TypeError, match="pass as a string instead"): |
jreback
approved these changes
Jun 14, 2020
Contributor
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically an API change, but AFAICT this isnt documented behavior anywhere.