From c05e4e97ca2f10a4bb201f2b702381b62640d23f Mon Sep 17 00:00:00 2001 From: vijayant Date: Thu, 24 Oct 2019 11:51:31 -0700 Subject: [PATCH 1/4] Adding test for assert_equal_index with empty iterables --- pandas/tests/util/test_assert_index_equal.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pandas/tests/util/test_assert_index_equal.py b/pandas/tests/util/test_assert_index_equal.py index 270f765caebd0..4f19c7036338c 100644 --- a/pandas/tests/util/test_assert_index_equal.py +++ b/pandas/tests/util/test_assert_index_equal.py @@ -171,3 +171,9 @@ def test_index_equal_category_mismatch(check_categorical): assert_index_equal(idx1, idx2, check_categorical=check_categorical) else: assert_index_equal(idx1, idx2, check_categorical=check_categorical) + + +def test_index_equal_empty_iterable(): + a = MultiIndex(levels=[[], []], codes=[[], []], names=['a', 'b']) + b = MultiIndex.from_arrays(arrays=[[], []], names=['a', 'b']) + assert_index_equal(a, b) From 31c0ad10453534c911e2bdf342ad682a0e35b346 Mon Sep 17 00:00:00 2001 From: vijayant Date: Thu, 24 Oct 2019 22:52:15 -0700 Subject: [PATCH 2/4] Adding issue # in comment --- pandas/tests/util/test_assert_index_equal.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pandas/tests/util/test_assert_index_equal.py b/pandas/tests/util/test_assert_index_equal.py index 4f19c7036338c..4cb1e614a6f0b 100644 --- a/pandas/tests/util/test_assert_index_equal.py +++ b/pandas/tests/util/test_assert_index_equal.py @@ -174,6 +174,7 @@ def test_index_equal_category_mismatch(check_categorical): def test_index_equal_empty_iterable(): + # #16844 a = MultiIndex(levels=[[], []], codes=[[], []], names=['a', 'b']) b = MultiIndex.from_arrays(arrays=[[], []], names=['a', 'b']) assert_index_equal(a, b) From efe93cd263e7484285dc4f7dcd6cea385c3e0fe2 Mon Sep 17 00:00:00 2001 From: vijayant Date: Sat, 26 Oct 2019 07:02:34 -0700 Subject: [PATCH 3/4] formatted file using black --- pandas/tests/util/test_assert_index_equal.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/tests/util/test_assert_index_equal.py b/pandas/tests/util/test_assert_index_equal.py index 4cb1e614a6f0b..44bee00501a3c 100644 --- a/pandas/tests/util/test_assert_index_equal.py +++ b/pandas/tests/util/test_assert_index_equal.py @@ -175,6 +175,6 @@ def test_index_equal_category_mismatch(check_categorical): def test_index_equal_empty_iterable(): # #16844 - a = MultiIndex(levels=[[], []], codes=[[], []], names=['a', 'b']) - b = MultiIndex.from_arrays(arrays=[[], []], names=['a', 'b']) + a = MultiIndex(levels=[[], []], codes=[[], []], names=["a", "b"]) + b = MultiIndex.from_arrays(arrays=[[], []], names=["a", "b"]) assert_index_equal(a, b) From 5b51becd9bd4f97bd4543101a45a01ce353fbfe8 Mon Sep 17 00:00:00 2001 From: vijayant Date: Tue, 29 Oct 2019 01:12:38 -0700 Subject: [PATCH 4/4] Move test to indexes/multi/test_constructor.py --- pandas/tests/indexes/multi/test_constructor.py | 7 +++++++ pandas/tests/util/test_assert_index_equal.py | 7 ------- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/pandas/tests/indexes/multi/test_constructor.py b/pandas/tests/indexes/multi/test_constructor.py index ff98da85cfb2d..c32adf275ac98 100644 --- a/pandas/tests/indexes/multi/test_constructor.py +++ b/pandas/tests/indexes/multi/test_constructor.py @@ -722,3 +722,10 @@ def test_from_frame_invalid_names(names, expected_error_msg): ) with pytest.raises(ValueError, match=expected_error_msg): pd.MultiIndex.from_frame(df, names=names) + + +def test_index_equal_empty_iterable(): + # #16844 + a = MultiIndex(levels=[[], []], codes=[[], []], names=["a", "b"]) + b = MultiIndex.from_arrays(arrays=[[], []], names=["a", "b"]) + tm.assert_index_equal(a, b) diff --git a/pandas/tests/util/test_assert_index_equal.py b/pandas/tests/util/test_assert_index_equal.py index 44bee00501a3c..270f765caebd0 100644 --- a/pandas/tests/util/test_assert_index_equal.py +++ b/pandas/tests/util/test_assert_index_equal.py @@ -171,10 +171,3 @@ def test_index_equal_category_mismatch(check_categorical): assert_index_equal(idx1, idx2, check_categorical=check_categorical) else: assert_index_equal(idx1, idx2, check_categorical=check_categorical) - - -def test_index_equal_empty_iterable(): - # #16844 - a = MultiIndex(levels=[[], []], codes=[[], []], names=["a", "b"]) - b = MultiIndex.from_arrays(arrays=[[], []], names=["a", "b"]) - assert_index_equal(a, b)