-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
STYLE autoupdate pre-commit #49406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
At what time tommorow will the autoupdate happen |
7 am UTC, but this PR can be done at any time |
I'll start it at 7 am then, |
it can be done before, the automated job will fail anyway so ideally we'd take your PR instead of the automated one |
Oh I'll start with it rightaway then |
While running the cython i found errors like some word defined but unused
So should I remove this dts word |
yeah looks like it's unused in that function, so you can just remove the |
Getting this error after running this |
could you please show me the output of |
Here it is |
I can't see what you've modified in |
Sorry here is the full output |
Should I open it or the full output is fine |
this isn't quite right - __lt__ = lambda self, other: (not isinstance(other, NegInfinity) and
+ __lt__ = def self, other: (not isinstance(other, NegInfinity) and
not missing.checknull(other)) you'll want something like
But yes, if you open a PR then it'll be easier to comment on specific lines |
Ok I'll do that |
How can we create the draft pull request from vscode |
I don't know about vscode, but see here for draft PRs https://github.blog/2019-02-14-introducing-draft-pull-requests/ it doesn't even have to be a draft PR, you can just put "WIP" in the title and I'll take a look whilst we fix up the error |
just getting back in 20 mins sir |
created a draft pull request sir |
Tomorrow, the autoupdate job will run, and there'll be a couple of updates which'll require some manual fixing:
The task is:
pre-commit autoupdate
pre-commit run cython-lint --all-files
andpre-commit run codespell --all-files
'use_time' defined but unused
, remove the definition ofuse_time
from that linePlease refer to the contributing guide, and feel free to ask if you run into anything unexpected (e.g. a false positive from the above tools)
The text was updated successfully, but these errors were encountered: