You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have trouble combining pandas with buildout. It looks like pandas depends on numpy during the setup phase, but it doesn't it declare the setup_requires (ref) directive in setup.py. Any reason why this feature remains unused, or shall I submit a pull request? Because I see the matplotlib and numexpr don't use it as well.
The text was updated successfully, but these errors were encountered:
matplotlib and numexpr are optional, numpy is not (it is needed from normal operation also, not only during setup phase.) numpy is mentioned in the install_requires argument to in setup.py. If numpy is not installed, installing pandas will also install numpy.
Fully agreed. But the setuptools spec says that when a dependency is needed both in runtime and in "setup" time, it needs to be added to both setup_requires and install_requires.
This causes buildout to assemble setup_requires packages first, and correctly makes them available to dependent packages during the setup phase. IMHO this is the desired behaviour for dependency resolution.
My point about the other libraries was that ideally, they should declare the same directive for all their setup-time dependencies as well :-)
are there any objections to this? assuming this doesn't add any complexity to travis builds i.e., it "just works" then a pr would be nice. and yes it would be nice if one didn't have to manually install numpy when one wanted to install mpl from pip same with scipy
We have trouble combining pandas with buildout. It looks like pandas depends on numpy during the setup phase, but it doesn't it declare the
setup_requires
(ref) directive in setup.py. Any reason why this feature remains unused, or shall I submit a pull request? Because I see the matplotlib and numexpr don't use it as well.The text was updated successfully, but these errors were encountered: