Skip to content

API: make tm.assert_foo_equal kwargs keyword-only for rarely-used keywords #38222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbrockmendel opened this issue Dec 2, 2020 · 2 comments
Closed
Labels
API Design Testing pandas testing functions or related to the test suite

Comments

@jbrockmendel
Copy link
Member

I expect this would need a deprecation cycle cc @jorisvandenbossche ?

@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member API Design Testing pandas testing functions or related to the test suite and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 2, 2020
@jorisvandenbossche
Copy link
Member

Is there a reason you closed this? (I think this is a good idea)

We should have the infrastructure to deprecate it (I think we did something similar for eg read_html), if we want that

@jbrockmendel
Copy link
Member Author

I tend to prune my own open issues fairly aggressively. I may come back to it sooner or later, but there are much higher priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

2 participants