comparison_with_sql document: adding a calculated column

[DavidRosen]

https://pandas-docs.github.io/pandas-docs-travis/getting_started/comparison/comparison_with_sql.html

In section "SELECT", the important use case of adding a calculated column is omitted.

I suggest adding something like the following:

select *, tip/total_bill as tip_rate from tips

pd.concat([tips, pd.Series(tips.tip/tips.total_bill, name='tip_rate')], axis=1)

[TomAugspurger]

I would write this as

tips.assign(
    tip_rate = tips['tip'] / tips['total_bill']
)

are you interested in adding this example @DavidRosen?

[DavidRosen]

are you interested in adding this example @DavidRosen?

@TomAugspurger, I'm a novice and really don't know what's involved in adding to the docs.

[TomAugspurger]

Dev guide is at https://dev.pandas.io/development/contributing.html#

…

On Aug 26, 2019, at 22:23, DavidRosen ***@***.***> wrote: are you interested in adding this example @DavidRosen? @TomAugspurger, I'm a novice and really don't know what's involved in adding to the docs. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[DavidRosen]

Come to think of it, why do we even need .assign() ? How about just:

tips['tip_rate'] = tips['tip'] / tips['total_bill']

BTW, this also has the advantage that the linter won't prohibit spaces around the "=" as it did when we used .assign() (because "=" was for a keyword argument).

[lucassa3]

Hi @TomAugspurger, I just referenced this issue in a PR a while ago. I'm relatively new to contributing to open source projects, so I'd like you to review if this is what was proposed in this Issue.

Best,

Lucas

[TomAugspurger]

Hi @lucassa3. I think David submitted a PR but didn’t reference the issue. So we won’t need your PR for this issue.

It looks like you made your PR against your master branch. In the future you should target pandas’ master branch. Let us know if you need help finding another issue.

[lucassa3]

Yes, I accidentally forgot to change merge target when opening the PR. I'll check other issues around, but thanks for the feedback Tom!

[TomAugspurger]

Closed by #28182.