Skip to content

CI failing - All builds are failing on python 3.5 on pytest 4.6 #26614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simonjayhawkins opened this issue Jun 2, 2019 · 5 comments · Fixed by #26619
Closed

CI failing - All builds are failing on python 3.5 on pytest 4.6 #26614

simonjayhawkins opened this issue Jun 2, 2019 · 5 comments · Fixed by #26619
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Milestone
0.25.0

Comments

@simonjayhawkins
Copy link
Member

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=12138

cc @pandas-dev/pandas-core
@simonjayhawkins simonjayhawkins added CI Continuous Integration Python 3.5 labels Jun 2, 2019
@WillAyd
Copy link
Member

WillAyd commented Jun 2, 2019

Might be a result of the jump from pytest 4.5 to 4.6, though wasn't able to reproduce locally

@h-vetinari
Copy link
Contributor

It is a pytest issue: pytest-dev/pytest#5358. Would help to pin "pytest<4.6" for now.

@simonjayhawkins simonjayhawkins mentioned this issue Jun 2, 2019
Closed
@simonjayhawkins simonjayhawkins changed the title CI failing - TypeError: 'NoneType' object is not iterable CI failing - All builds are failing on python 3.5 on pytest 4.6 Jun 2, 2019
@simonjayhawkins simonjayhawkins added the Dependencies Required and optional dependencies label Jun 2, 2019
@jreback
Copy link
Contributor

jreback commented Jun 2, 2019

we can pin those builds specifically

@simonjayhawkins
Copy link
Member Author

just about to submit PR, may have the syntax wrong though

# universal
- pytest>=4.0.2,!=4.6.0

@jreback
Copy link
Contributor

jreback commented Jun 2, 2019

use<4.6 (or for those older builds just pin directly to a single version

@simonjayhawkins simonjayhawkins added this to the 0.25.0 milestone Jun 2, 2019
@simonjayhawkins simonjayhawkins mentioned this issue Jun 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

CI: pin pytest version on Python 3.5 simonjayhawkins/pandas
4 participants
@WillAyd @jreback @simonjayhawkins @h-vetinari