Skip to content

CLN: Remove pd.util._depr_module? #25200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbrockmendel opened this issue Feb 7, 2019 · 5 comments
Closed

CLN: Remove pd.util._depr_module? #25200

jbrockmendel opened this issue Feb 7, 2019 · 5 comments
Labels

Comments

@jbrockmendel
Copy link
Member

AFAICT it isn't used anywhere

@gfyoung
Copy link
Member

gfyoung commented Feb 7, 2019

Hold onto this for now. We used it for deprecating entire modules. I doubt that such a use case will not come along in the future.

@gfyoung gfyoung added the Clean label Feb 7, 2019
@jreback
Copy link
Contributor

jreback commented Feb 7, 2019

i think we used this to deprecate datetools

+.25 with removing its potentially useful

@gfyoung
Copy link
Member

gfyoung commented Feb 9, 2019

i think we used this to deprecate datetools

@jreback : Yes, that's right. This was a pretty nifty way of doing so, so I'm not really inclined to remove it any time soon given its usefulness.

@jbrockmendel
Copy link
Member Author

Could we move it somewhere outside of the pandas/ directory? It adds noise to coverage stats #26877.

@gfyoung
Copy link
Member

gfyoung commented Jul 15, 2019

Is it possible to ignore coverage for those lines? I would prefer that. The reason is that this is a really useful utility that we may want to reuse in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants