Skip to content

DES: Should util.is_nan check for complex('nan')? #24607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Jan 4, 2019 · 0 comments · Fixed by #24628
Closed

DES: Should util.is_nan check for complex('nan')? #24607

jbrockmendel opened this issue Jan 4, 2019 · 0 comments · Fixed by #24628
Labels
Complex Complex Numbers Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Milestone
0.24.0

Comments

@jbrockmendel
Copy link
Member

It doesn't at the moment. A handful of functions in libs.missing do check for complex nan, and could be simplified/de-duplicated if we make util.is_nan also catch the complex case.
This was referenced Jan 4, 2019
Merged
Merged
@jreback jreback added the Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate label Jan 5, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 5, 2019
@jreback jreback added the Complex Complex Numbers label Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complex Complex Numbers Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

catch complex nan in util.is_nan, de-dup+optimize libmissing, tests jbrockmendel/pandas
2 participants
@jreback @jbrockmendel