Skip to content

Parameter nrows is not documented in DataFrame.from_records() #23445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrism2671 opened this issue Nov 1, 2018 · 5 comments
Closed

Parameter nrows is not documented in DataFrame.from_records() #23445

chrism2671 opened this issue Nov 1, 2018 · 5 comments
Labels
DataFrame DataFrame data structure Docs good first issue IO Data IO issues that don't fit into a more specific label
Milestone
0.24.0

Comments

@chrism2671
Copy link

classmethod DataFrame.from_records(data, index=None, exclude=None, columns=None, coerce_float=False, nrows=None)

The documentation is lacking an explanation for the nrows paramater.

http://pandas.pydata.org/pandas-docs/stable/generated/pandas.DataFrame.from_records.html
@jreback
Copy link
Contributor

jreback commented Nov 1, 2018

iirc this is a duplicate issue can u look

@chrism2671
Copy link
Author

I did check before posting.

@gfyoung gfyoung added Docs IO Data IO issues that don't fit into a more specific label DataFrame DataFrame data structure good first issue labels Nov 1, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Nov 1, 2018
@gfyoung
Copy link
Member

gfyoung commented Nov 1, 2018

Seems like a relatively trivial documentation issue. Should try to add before next release.

@chrism2671 : You are more than welcome to tackle this if you want!

@jorisvandenbossche jorisvandenbossche modified the milestones: 0.24.0, Contributions Welcome Nov 8, 2018
@rookiedk
Copy link

rookiedk commented Nov 16, 2018 •
edited
Loading

Is this still open? I would love to make this my first pull-request to pandas.

@nmusolino
Copy link
Contributor

nmusolino commented Dec 1, 2018 •
edited
Loading

This parameter is now documented in the master branch (for the forthcoming 0.24 release), and this issue can be closed.

Link to master branch documentation: http://pandas-docs.github.io/pandas-docs-travis/generated/pandas.DataFrame.from_records.html?highlight=from_records#pandas.DataFrame.from_records

Credit goes to @mortada for adding this earlier in 2018: #21735

@gfyoung gfyoung modified the milestones: Contributions Welcome, 0.24.0 Dec 2, 2018
@gfyoung gfyoung closed this as completed Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DataFrame DataFrame data structure Docs good first issue IO Data IO issues that don't fit into a more specific label
Projects
None yet
Milestone
0.24.0
Development

No branches or pull requests
6 participants
@chrism2671 @jreback @jorisvandenbossche @nmusolino @gfyoung @rookiedk