Skip to content

CLN: Returned dtype of _get_cython_function unused #19557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WillAyd opened this issue Feb 6, 2018 · 1 comment · Fixed by #19561
Closed

CLN: Returned dtype of _get_cython_function unused #19557

WillAyd opened this issue Feb 6, 2018 · 1 comment · Fixed by #19561

Comments

@WillAyd
Copy link
Member

WillAyd commented Feb 6, 2018

Minor code cleanup opportunity here. _get_cython_function in core/groupby returns a tuple containing a function and a dtype_str. While the latter is unpacked, it never appears to be used in code that calls it.

return func, dtype_str

As an alternate to removing it, it may serve some purpose if the below line is refactored to use it rather than creating its own local variable, but unless there's some other purposes I'd still just suggest cleaning up the _get_cython_function itself

out_dtype = '%s%d' % (values.dtype.kind, values.dtype.itemsize)

@jreback
Copy link
Contributor

jreback commented Feb 6, 2018

cleaning welcome! yeah the dtype_str is prob not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants