Skip to content

PERF: groupby regression #16598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue Jun 4, 2017 · 3 comments
Closed

PERF: groupby regression #16598

TomAugspurger opened this issue Jun 4, 2017 · 3 comments
Labels
Groupby Performance Memory or execution speed performance

Comments

@TomAugspurger
Copy link
Contributor

#16413 may have slowed down time_groupby_series_simple_cython (while speeding up other groupby ops)

$ asv continuous d5a681bfa~1 d5a681bfa -b groupby.groupby_multi.time_groupby_series_simple_cython 

· Creating environments
· Discovering benchmarks
·· Uninstalling from conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
·· Installing into conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt..
· Running 2 total benchmarks (2 commits * 1 environments * 1 benchmarks)
[  0.00%] · For pandas commit hash d5a681bf:
[  0.00%] ·· Building for conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt..........................................................................................
[  0.00%] ·· Benchmarking conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[ 50.00%] ··· Running groupby.groupby_multi.time_groupby_series_simple_cython                                                                                                                                                                                                                                    5.04±0.09ms
[ 50.00%] · For pandas commit hash 5fe042f5:
[ 50.00%] ·· Building for conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt..........................................................................................
[ 50.00%] ·· Benchmarking conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[100.00%] ··· Running groupby.groupby_multi.time_groupby_series_simple_cython                                                                                                                                                                                                                                    3.79±0.09ms       
       before           after         ratio
     [5fe042f5]       [d5a681bf]
+     3.79±0.09ms      5.04±0.09ms     1.33  groupby.groupby_multi.time_groupby_series_simple_cython

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
@TomAugspurger TomAugspurger added the Performance Memory or execution speed performance label Jun 4, 2017
@TomAugspurger TomAugspurger added this to the Next Major Release milestone Jun 4, 2017
@jreback jreback modified the milestones: 0.21.0, Next Major Release Jun 5, 2017
@jreback
Copy link
Contributor

jreback commented Sep 23, 2017

does this still showup?

@jreback jreback modified the milestones: 0.21.0, Next Major Release Oct 2, 2017
@jreback jreback added the Groupby label Oct 2, 2017
@rhshadrach
Copy link
Member

@TomAugspurger Is this still useful to have open?

@TomAugspurger
Copy link
Contributor Author

I don't see that benchmark anymore, so hard to say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Groupby Performance Memory or execution speed performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jreback @TomAugspurger @rhshadrach