Skip to content

TST: _reset_cache on any defined fixtures between tests #12150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Jan 26, 2016 · 2 comments
Closed

TST: _reset_cache on any defined fixtures between tests #12150

jreback opened this issue Jan 26, 2016 · 2 comments
Labels
Enhancement Testing pandas testing functions or related to the test suite

Comments

@jreback
Copy link
Contributor

jreback commented Jan 26, 2016

xref #12130

we should clear() the _cache variable (set by cache_readonly) in between unit tests. same with the DataFrame tests.

this will prevent any tests from mutating these 'fixtures' and causing issues in later tests
@jreback jreback added the Testing pandas testing functions or related to the test suite label Jan 26, 2016
@jreback jreback added this to the 0.18.0 milestone Jan 26, 2016
@jreback
Copy link
Contributor Author

jreback commented Jan 26, 2016

cc @wesm

@jreback jreback changed the title TST: clear _reset_cache on any defined fixtures between tests TST: _reset_cache on any defined fixtures between tests Jan 26, 2016
@jreback jreback modified the milestones: 0.18.1, 0.18.0 Feb 9, 2016
@jreback jreback modified the milestones: 0.18.2, 0.18.1 Apr 18, 2016
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, 0.19.0 Sep 1, 2016
@jreback jreback modified the milestones: 0.20.0, Next Major Release Mar 23, 2017
@jbrockmendel
Copy link
Member

Our fixtures generally create new objects for each test. I don't think there's anything to do here. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jreback @jorisvandenbossche @jbrockmendel @mroeschke