Skip to content

Client Secrets file in the gbq.py #10754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snamburi3 opened this issue Aug 5, 2015 · 6 comments
Closed

Client Secrets file in the gbq.py #10754

snamburi3 opened this issue Aug 5, 2015 · 6 comments

Comments

@snamburi3
Copy link

https://github.com/pydata/pandas/blob/master/pandas/io/gbq.py#L102
Why is this in the gbq.py? can we set this as an environmental Variable?

@TomAugspurger
Copy link
Contributor

cc @jacobschaer

@snamburi3
Copy link
Author

Thanks. I think the best way would be to set GOOGLE_APPLICATION_CREDENTIALS in the script overriding the gbq.py defaults...
https://developers.google.com/identity/protocols/application-default-credentials

@snamburi3
Copy link
Author

Or, can we switch to gcloud-python bigquery. We need to just set GOOGLE_APPLICATION_CREDENTIALS and then we are done. Thanks you all.

@jacobschaer
Copy link
Contributor

I believe those credentials were to simplify the authentication flow. We created a Pandas GBQ google account so when the authentication flow pops a browser for credentials it can give a customized description of what the credentials are needed for (in case the user is unsure). It also lets us get a sense of how popular the module is in the sense of people actually authenticating with it.

Also, I think that non-application tokens had a rather restrictive expiration time.

@sean-schaefer - Sound right?

@parthea
Copy link
Contributor

parthea commented Sep 18, 2015

I've committed a change to the authentication flow in #11141. The authentication worked without modifying client_secret.

@parthea
Copy link
Contributor

parthea commented Sep 10, 2016

@jreback @snamburi3 Can this be closed? Pandas supports application default credentials with PR #13608

@jreback jreback closed this as completed Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants