Skip to content

Commit 7edfaef

Browse files
sumanau7Sumanau Sareen
authored and
Sumanau Sareen
committed
Send None parameter to pandas-gbq to set no progress bar
1 parent 556e1c2 commit 7edfaef

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

pandas/io/gbq.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,14 +162,13 @@ def read_gbq(
162162
"""
163163
pandas_gbq = _try_import()
164164

165-
kwargs: Dict[str, Union[str, bool]] = {}
165+
kwargs: Dict[str, Union[str, bool, None]] = {}
166166

167167
# START: new kwargs. Don't populate unless explicitly set.
168168
if use_bqstorage_api is not None:
169169
kwargs["use_bqstorage_api"] = use_bqstorage_api
170170

171-
if progress_bar_type is not None:
172-
kwargs["progress_bar_type"] = progress_bar_type
171+
kwargs["progress_bar_type"] = progress_bar_type
173172
# END: new kwargs
174173

175174
return pandas_gbq.read_gbq(

pandas/tests/io/test_gbq.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,7 @@ def mock_read_gbq(sql, **kwargs):
142142

143143
monkeypatch.setattr("pandas_gbq.read_gbq", mock_read_gbq)
144144
pd.read_gbq("SELECT 1", progress_bar_type=progress_bar)
145-
146-
if progress_bar:
147-
assert "progress_bar_type" in captured_kwargs
148-
else:
149-
assert "progress_bar_type" not in captured_kwargs
145+
assert "progress_bar_type" in captured_kwargs
150146

151147

152148
@pytest.mark.single

0 commit comments

Comments
 (0)