Skip to content

Commit 7bc02ae

Browse files
howsiweiSi Wei How
authored and
Si Wei How
committed
Rewrite tests
1 parent 85b67fd commit 7bc02ae

File tree

1 file changed

+12
-27
lines changed

1 file changed

+12
-27
lines changed

pandas/tests/frame/test_indexing.py

Lines changed: 12 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -190,46 +190,31 @@ def test_setitem_list_all_missing_columns_scalar(self):
190190
df = self.frame.copy()
191191
df[['E', 'F']] = 1
192192

193-
result = df.columns
194-
expected = self.frame.columns.union(['E', 'F'])
195-
assert_index_equal(result, expected)
193+
df2 = self.frame.copy()
194+
df2['E'] = 1
195+
df2['F'] = 1
196196

197-
result = df[self.frame.columns]
198-
expected = self.frame
199-
assert_frame_equal(result, expected)
200-
201-
assert (df[['E', 'F']] == 1).all().all()
197+
assert_frame_equal(df, df2)
202198

203199
def test_setitem_list_some_missing_columns_list(self):
204200
df = self.frame.copy()
205201
df[['A', 'E']] = [1, 2]
206202

207-
result = df.columns
208-
expected = self.frame.columns.union(['E'])
209-
assert_index_equal(result, expected)
210-
211-
result = df[self.frame.columns.drop('A')]
212-
expected = self.frame.drop('A', axis=1)
213-
assert_frame_equal(result, expected)
203+
df2 = self.frame.copy()
204+
df2['A'] = 1
205+
df2['E'] = 2
214206

215-
assert (df['A'] == 1).all()
216-
assert (df['E'] == 2).all()
207+
assert_frame_equal(df, df2)
217208

218209
def test_setitem_list_some_missing_columns_dataframe(self):
219210
df = self.frame.copy()
220211
df[['A', 'E']] = self.frame[['B', 'C']]
221212

222-
result = df.columns
223-
expected = self.frame.columns.union(['E'])
224-
assert_index_equal(result, expected)
225-
226-
result = df[self.frame.columns.drop('A')]
227-
expected = self.frame.drop('A', axis=1)
228-
assert_frame_equal(result, expected)
213+
df2 = self.frame.copy()
214+
df2['A'] = self.frame['B']
215+
df2['E'] = self.frame['C']
229216

230-
result = df[['A', 'E']]
231-
expected = self.frame[['B', 'C']]
232-
assert_numpy_array_equal(result.to_numpy(), expected.to_numpy())
217+
assert_frame_equal(df, df2)
233218

234219
def test_setitem_mulit_index(self):
235220
# GH7655, test that assigning to a sub-frame of a frame

0 commit comments

Comments
 (0)