ENH: refactored Series plotting methods to use common code. clean up default arguments

Author: wesm

pandas/core/index.py

@@ -150,12 +150,6 @@ def is_monotonic(self):
     def is_numeric(self):
         return self.inferred_type in ['integer', 'floating']
 
-    def is_datetype(self):
-        for key in self.values:
-            if not isinstance(key, (datetime, date)):
-                return False
-        return True
-
     def get_duplicates(self):
         from collections import defaultdict
         counter = defaultdict(lambda: 0)

pandas/src/inference.pyx

@@ -191,6 +191,15 @@ def is_datetime_array(ndarray[object] values):
             return False
     return True
 
+def is_date_array(ndarray[object] values):
+    cdef int i, n = len(values)
+    if n == 0:
+        return False
+    for i in range(n):
+        if not is_date(values[i]):
+            return False
+    return True
+
 
 def maybe_convert_numeric(ndarray[object] values, set na_values):
     '''

pandas/src/tseries.pyx

@@ -50,6 +50,7 @@ cdef extern from "datetime.h":
     int PyDateTime_TIME_GET_SECOND(datetime o)
     int PyDateTime_TIME_GET_MICROSECOND(datetime o)
     bint PyDateTime_Check(object o)
+    bint PyDate_Check(object o)
     void PyDateTime_IMPORT()
 
 # import datetime C API

pandas/tests/test_tseries.py

@@ -347,10 +347,16 @@ def test_unicode(self):
         pass
 
     def test_datetime(self):
-        pass
+        import datetime
+        dates = [datetime.datetime(2012, 1, x) for x in range(1, 20)]
+        index = Index(dates)
+        self.assert_(index.inferred_type == 'datetime')
 
     def test_date(self):
-        pass
+        import datetime
+        dates = [datetime.date(2012, 1, x) for x in range(1, 20)]
+        index = Index(dates)
+        self.assert_(index.inferred_type == 'date')
 
     def test_to_object_array_tuples(self):
         r = (5,6)