fixed data check in create_series_with_explicit_index + renmae of helper

Author: SaturnFromTitan

pandas/core/construction.py

@@ -626,7 +626,7 @@ def create_series_with_explicit_dtype(
     if is_empty_data(data) and dtype is None:
         dtype = dtype_if_empty
 
-    return create_series_with_explicit_index_type(
+    return create_series_with_explicit_index(
         data=data,
         index=index,
         dtype=dtype,
@@ -637,7 +637,7 @@ def create_series_with_explicit_dtype(
     )
 
 
-def create_series_with_explicit_index_type(
+def create_series_with_explicit_index(
     data: Any = None,
     index: Optional[Union[ArrayLike, "Index"]] = None,
     dtype: Optional[Dtype] = None,
@@ -674,7 +674,7 @@ def create_series_with_explicit_index_type(
     if index_if_empty is None:
         index_if_empty = Index([])
 
-    if index is None and data == []:
+    if index is None and isinstance(data, list) and len(data) == 0:
         index = index_if_empty
     return Series(
         data=data, index=index, dtype=dtype, name=name, copy=copy, fastpath=fastpath

pandas/tests/series/indexing/test_boolean.py

@@ -3,7 +3,7 @@
 
 from pandas import Index, Series
 import pandas._testing as tm
-from pandas.core.construction import create_series_with_explicit_index_type
+from pandas.core.construction import create_series_with_explicit_index
 from pandas.core.indexing import IndexingError
 
 from pandas.tseries.offsets import BDay
@@ -21,7 +21,7 @@ def test_getitem_boolean(string_series):
 
 
 def test_getitem_boolean_empty():
-    s = create_series_with_explicit_index_type([], dtype=np.int64)
+    s = create_series_with_explicit_index([], dtype=np.int64)
     s.index.name = "index_name"
     s = s[s.isna()]
     assert s.index.name == "index_name"
@@ -31,7 +31,7 @@ def test_getitem_boolean_empty():
     # indexing with empty series
     s = Series(["A", "B"])
     expected = Series(dtype=object, index=Index([], dtype="int64"))
-    result = s[create_series_with_explicit_index_type([], dtype=object)]
+    result = s[create_series_with_explicit_index([], dtype=object)]
     tm.assert_series_equal(result, expected)
 
     # invalid because of the boolean indexer
@@ -41,7 +41,7 @@ def test_getitem_boolean_empty():
         r"the boolean Series and of the indexed object do not match"
     )
     with pytest.raises(IndexingError, match=msg):
-        s[create_series_with_explicit_index_type([], dtype=bool)]
+        s[create_series_with_explicit_index([], dtype=bool)]
 
     with pytest.raises(IndexingError, match=msg):
         s[Series([True], dtype=bool)]

pandas/tests/series/indexing/test_indexing.py

@@ -10,7 +10,7 @@
 import pandas as pd
 from pandas import Categorical, DataFrame, MultiIndex, Series, Timedelta, Timestamp
 import pandas._testing as tm
-from pandas.core.construction import create_series_with_explicit_index_type
+from pandas.core.construction import create_series_with_explicit_index
 
 from pandas.tseries.offsets import BDay
 
@@ -618,7 +618,7 @@ def test_setitem_na():
 
 def test_timedelta_assignment():
     # GH 8209
-    s = create_series_with_explicit_index_type([], dtype=object)
+    s = create_series_with_explicit_index([], dtype=object)
     s.loc["B"] = timedelta(1)
     tm.assert_series_equal(s, Series(Timedelta("1 days"), index=["B"]))
 

pandas/tests/series/methods/test_drop_duplicates.py

@@ -3,7 +3,7 @@
 
 from pandas import Categorical, Series
 import pandas._testing as tm
-from pandas.core.construction import create_series_with_explicit_index_type
+from pandas.core.construction import create_series_with_explicit_index
 
 
 @pytest.mark.parametrize(
@@ -47,8 +47,8 @@ def test_drop_duplicates_bool(keep, expected):
 
 @pytest.mark.parametrize("values", [[], list(range(5))])
 def test_drop_duplicates_no_duplicates(any_numpy_dtype, keep, values):
-    tc = create_series_with_explicit_index_type(values, dtype=np.dtype(any_numpy_dtype))
-    expected = create_series_with_explicit_index_type([False] * len(tc), dtype="bool")
+    tc = create_series_with_explicit_index(values, dtype=np.dtype(any_numpy_dtype))
+    expected = create_series_with_explicit_index([False] * len(tc), dtype="bool")
 
     if tc.dtype == "bool":
         # 0 -> False and 1-> True

pandas/tests/series/methods/test_quantile.py

@@ -6,7 +6,7 @@
 import pandas as pd
 from pandas import Index, Series
 import pandas._testing as tm
-from pandas.core.construction import create_series_with_explicit_index_type
+from pandas.core.construction import create_series_with_explicit_index
 from pandas.core.indexes.datetimes import Timestamp
 
 
@@ -105,7 +105,7 @@ def test_quantile_nan(self):
         assert result == expected
 
         # all nan/empty
-        s1 = create_series_with_explicit_index_type([], dtype=object)
+        s1 = create_series_with_explicit_index([], dtype=object)
         cases = [s1, Series([np.nan, np.nan])]
 
         for s in cases:
@@ -165,10 +165,10 @@ def test_quantile_box(self, case):
     def test_datetime_timedelta_quantiles(self):
         # covers #9694
         assert pd.isna(
-            create_series_with_explicit_index_type([], dtype="M8[ns]").quantile(0.5)
+            create_series_with_explicit_index([], dtype="M8[ns]").quantile(0.5)
         )
         assert pd.isna(
-            create_series_with_explicit_index_type([], dtype="m8[ns]").quantile(0.5)
+            create_series_with_explicit_index([], dtype="m8[ns]").quantile(0.5)
         )
 
     def test_quantile_nat(self):
@@ -191,7 +191,7 @@ def test_quantile_sparse(self, values, dtype):
     def test_quantile_empty(self):
 
         # floats
-        s = create_series_with_explicit_index_type([], dtype="float64")
+        s = create_series_with_explicit_index([], dtype="float64")
 
         res = s.quantile(0.5)
         assert np.isnan(res)
@@ -201,7 +201,7 @@ def test_quantile_empty(self):
         tm.assert_series_equal(res, exp)
 
         # int
-        s = create_series_with_explicit_index_type([], dtype="int64")
+        s = create_series_with_explicit_index([], dtype="int64")
 
         res = s.quantile(0.5)
         assert np.isnan(res)
@@ -211,7 +211,7 @@ def test_quantile_empty(self):
         tm.assert_series_equal(res, exp)
 
         # datetime
-        s = create_series_with_explicit_index_type([], dtype="datetime64[ns]")
+        s = create_series_with_explicit_index([], dtype="datetime64[ns]")
 
         res = s.quantile(0.5)
         assert res is pd.NaT

pandas/tests/series/test_apply.py

@@ -10,7 +10,7 @@
 from pandas import DataFrame, Index, Series, isna
 import pandas._testing as tm
 from pandas.core.base import SpecificationError
-from pandas.core.construction import create_series_with_explicit_index_type
+from pandas.core.construction import create_series_with_explicit_index
 
 
 class TestSeriesApply:
@@ -520,7 +520,7 @@ def test_map_empty(self, indices):
         if isinstance(indices, ABCMultiIndex):
             pytest.skip("Initializing a Series from a MultiIndex is not supported")
 
-        s = create_series_with_explicit_index_type(indices)
+        s = create_series_with_explicit_index(indices)
         result = s.map({})
 
         expected = pd.Series(np.nan, index=s.index)

pandas/tests/series/test_combine_concat.py

@@ -3,7 +3,7 @@
 
 import pandas as pd
 from pandas import Series
-from pandas.core.construction import create_series_with_explicit_index_type
+from pandas.core.construction import create_series_with_explicit_index
 
 
 class TestSeriesConcat:
@@ -96,9 +96,7 @@ def test_concat_empty_series_dtype_category_with_array(self):
         assert (
             pd.concat(
                 [
-                    create_series_with_explicit_index_type(
-                        np.array([]), dtype="category"
-                    ),
+                    create_series_with_explicit_index(np.array([]), dtype="category"),
                     Series(dtype="float64"),
                 ]
             ).dtype

pandas/tests/series/test_constructors.py

@@ -28,7 +28,7 @@
 )
 import pandas._testing as tm
 from pandas.core.arrays import IntervalArray, period_array
-from pandas.core.construction import create_series_with_explicit_index_type
+from pandas.core.construction import create_series_with_explicit_index
 
 
 class TestSeriesConstructors:
@@ -1401,7 +1401,7 @@ def test_constructor_generic_timestamp_no_frequency(self, dtype):
         msg = "dtype has no unit. Please pass in"
 
         with pytest.raises(ValueError, match=msg):
-            create_series_with_explicit_index_type([], dtype=dtype)
+            create_series_with_explicit_index([], dtype=dtype)
 
     @pytest.mark.parametrize(
         "dtype,msg",
@@ -1414,7 +1414,7 @@ def test_constructor_generic_timestamp_bad_frequency(self, dtype, msg):
         # see gh-15524, gh-15987
 
         with pytest.raises(TypeError, match=msg):
-            create_series_with_explicit_index_type([], dtype=dtype)
+            create_series_with_explicit_index([], dtype=dtype)
 
     @pytest.mark.parametrize("dtype", [None, "uint8", "category"])
     def test_constructor_range_dtype(self, dtype):

pandas/tests/series/test_dtypes.py

@@ -21,7 +21,7 @@
     date_range,
 )
 import pandas._testing as tm
-from pandas.core.construction import create_series_with_explicit_index_type
+from pandas.core.construction import create_series_with_explicit_index
 
 
 class TestSeriesDtypes:
@@ -405,9 +405,9 @@ def test_astype_empty_constructor_equality(self, dtype):
             "M",
             "m",  # Generic timestamps raise a ValueError. Already tested.
         ):
-            init_empty = create_series_with_explicit_index_type([], dtype=dtype)
+            init_empty = create_series_with_explicit_index([], dtype=dtype)
             with tm.assert_produces_warning(DeprecationWarning, check_stacklevel=False):
-                as_type_empty = create_series_with_explicit_index_type([]).astype(dtype)
+                as_type_empty = create_series_with_explicit_index([]).astype(dtype)
             tm.assert_series_equal(init_empty, as_type_empty)
 
     def test_arg_for_errors_in_astype(self):

pandas/tests/series/test_duplicates.py

@@ -5,7 +5,7 @@
 import pandas._testing as tm
 from pandas.core.construction import (
     create_series_with_explicit_dtype,
-    create_series_with_explicit_index_type,
+    create_series_with_explicit_index,
 )
 
 
@@ -18,7 +18,7 @@ def test_nunique():
     assert result == 11
 
     # GH 18051
-    s = create_series_with_explicit_index_type(Categorical([]))
+    s = create_series_with_explicit_index(Categorical([]))
     assert s.nunique() == 0
     s = Series(Categorical([np.nan]))
     assert s.nunique() == 0
@@ -49,7 +49,7 @@ def test_unique():
     tm.assert_numpy_array_equal(result, expected)
 
     # GH 18051
-    s = create_series_with_explicit_index_type(Categorical([]))
+    s = create_series_with_explicit_index(Categorical([]))
     tm.assert_categorical_equal(s.unique(), Categorical([]))
     s = Series(Categorical([np.nan]))
     tm.assert_categorical_equal(s.unique(), Categorical([np.nan]))

pandas/tests/series/test_missing.py

@@ -20,7 +20,7 @@
     isna,
 )
 import pandas._testing as tm
-from pandas.core.construction import create_series_with_explicit_index_type
+from pandas.core.construction import create_series_with_explicit_index
 
 
 class TestSeriesMissingData:
@@ -563,7 +563,7 @@ def test_fillna(self, datetime_series):
         tm.assert_series_equal(result, expected)
         result = s1.fillna({})
         tm.assert_series_equal(result, s1)
-        result = s1.fillna(create_series_with_explicit_index_type((), dtype=object))
+        result = s1.fillna(create_series_with_explicit_index((), dtype=object))
         tm.assert_series_equal(result, s1)
         result = s2.fillna(s1)
         tm.assert_series_equal(result, s2)
@@ -678,7 +678,7 @@ def test_timedelta64_nan(self):
         #     tm.assert_series_equal(selector, expected)
 
     def test_dropna_empty(self):
-        s = create_series_with_explicit_index_type([], dtype=object)
+        s = create_series_with_explicit_index([], dtype=object)
 
         assert len(s.dropna()) == 0
         s.dropna(inplace=True)

pandas/tests/series/test_operators.py

@@ -8,7 +8,7 @@
 from pandas import DataFrame, Index, Series, bdate_range
 import pandas._testing as tm
 from pandas.core import ops
-from pandas.core.construction import create_series_with_explicit_index_type
+from pandas.core.construction import create_series_with_explicit_index
 
 
 class TestSeriesLogicalOps:
@@ -33,7 +33,7 @@ def test_logical_operators_bool_dtype_with_empty(self):
 
         s_tft = Series([True, False, True], index=index)
         s_fff = Series([False, False, False], index=index)
-        s_empty = create_series_with_explicit_index_type([], dtype=object)
+        s_empty = create_series_with_explicit_index([], dtype=object)
 
         res = s_tft & s_empty
         expected = s_fff
@@ -408,7 +408,7 @@ def test_logical_ops_label_based(self):
         # filling
 
         # vs empty
-        empty = create_series_with_explicit_index_type([], dtype=object)
+        empty = create_series_with_explicit_index([], dtype=object)
 
         result = a & empty.copy()
         expected = Series([False, False, False], list("bca"))

pandas/tests/series/test_repr.py

@@ -16,7 +16,7 @@
     timedelta_range,
 )
 import pandas._testing as tm
-from pandas.core.construction import create_series_with_explicit_index_type
+from pandas.core.construction import create_series_with_explicit_index
 
 
 class TestSeriesRepr:
@@ -125,10 +125,10 @@ def test_repr(self, datetime_series, string_series, object_series):
         assert "a\n" not in repr(ser)
 
         # with empty series (#4651)
-        s = create_series_with_explicit_index_type([], dtype=np.int64, name="foo")
+        s = create_series_with_explicit_index([], dtype=np.int64, name="foo")
         assert repr(s) == "Series([], Name: foo, dtype: int64)"
 
-        s = create_series_with_explicit_index_type([], dtype=np.int64, name=None)
+        s = create_series_with_explicit_index([], dtype=np.int64, name=None)
         assert repr(s) == "Series([], dtype: int64)"
 
     def test_tidy_repr(self):