From 8429c18be697d1df779392b014df24bdf40861af Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Sat, 29 Oct 2022 13:10:47 +0530 Subject: [PATCH 1/7] for #392 added dict --- pandas-stubs/core/frame.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas-stubs/core/frame.pyi b/pandas-stubs/core/frame.pyi index a65e6e1d9..3b818ff3d 100644 --- a/pandas-stubs/core/frame.pyi +++ b/pandas-stubs/core/frame.pyi @@ -192,7 +192,7 @@ class DataFrame(NDFrame, OpsMixin): data: ListLikeU | DataFrame | dict[Any, Any] - | Iterable[ListLikeU | tuple[Hashable, ListLikeU]] + | Iterable[ListLikeU | tuple[Hashable, ListLikeU] | dict[Any,Any]] | None = ..., index: Axes | None = ..., columns: Axes | None = ..., From 245dff73f596359b7e868fd0c153db42517435b7 Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Sat, 29 Oct 2022 13:14:04 +0530 Subject: [PATCH 2/7] for #392 --- pandas-stubs/core/frame.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas-stubs/core/frame.pyi b/pandas-stubs/core/frame.pyi index 3b818ff3d..7d49cf35b 100644 --- a/pandas-stubs/core/frame.pyi +++ b/pandas-stubs/core/frame.pyi @@ -192,7 +192,7 @@ class DataFrame(NDFrame, OpsMixin): data: ListLikeU | DataFrame | dict[Any, Any] - | Iterable[ListLikeU | tuple[Hashable, ListLikeU] | dict[Any,Any]] + | Iterable[ListLikeU | tuple[Hashable, ListLikeU] | dict[Any, Any]] | None = ..., index: Axes | None = ..., columns: Axes | None = ..., From 700da0f3b44fb4344ff2f039068d82e58297f0d9 Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Mon, 31 Oct 2022 21:21:40 +0530 Subject: [PATCH 3/7] adding test for #392 --- tests/test_frame.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/test_frame.py b/tests/test_frame.py index 977dd7f2c..68627e562 100644 --- a/tests/test_frame.py +++ b/tests/test_frame.py @@ -1915,3 +1915,8 @@ def f(s: pd.DataFrame) -> pd.Series: return s.mean() check(assert_type(resampler.apply(f), Union[pd.Series, pd.DataFrame]), pd.DataFrame) + + +def df_accepting_dicts_iterator() -> None: + data = [{"a": 1, "b": 2}, {"a": 3, "b": 5}] + p = pd.DataFrame(iter(data)) From cd7bd88607f6e79655cae34cbb58da3e9bd7203d Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Tue, 1 Nov 2022 00:49:30 +0530 Subject: [PATCH 4/7] update --- tests/test_frame.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_frame.py b/tests/test_frame.py index 68627e562..b134e34c5 100644 --- a/tests/test_frame.py +++ b/tests/test_frame.py @@ -1917,6 +1917,6 @@ def f(s: pd.DataFrame) -> pd.Series: check(assert_type(resampler.apply(f), Union[pd.Series, pd.DataFrame]), pd.DataFrame) -def df_accepting_dicts_iterator() -> None: +def df_accepting_dicts_iterator() -> None: # GH 392 data = [{"a": 1, "b": 2}, {"a": 3, "b": 5}] p = pd.DataFrame(iter(data)) From 01ff2112ab8dc5b126eb18c7cdd5e28b7a221420 Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Tue, 1 Nov 2022 01:10:28 +0530 Subject: [PATCH 5/7] update --- tests/test_frame.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/test_frame.py b/tests/test_frame.py index b134e34c5..140ffe724 100644 --- a/tests/test_frame.py +++ b/tests/test_frame.py @@ -1915,8 +1915,9 @@ def f(s: pd.DataFrame) -> pd.Series: return s.mean() check(assert_type(resampler.apply(f), Union[pd.Series, pd.DataFrame]), pd.DataFrame) - - -def df_accepting_dicts_iterator() -> None: # GH 392 + + +def df_accepting_dicts_iterator() -> None: + # GH 392 data = [{"a": 1, "b": 2}, {"a": 3, "b": 5}] p = pd.DataFrame(iter(data)) From 376e4ddd4ddc67abcf73213880bafb45a6bb1e43 Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Tue, 1 Nov 2022 01:21:15 +0530 Subject: [PATCH 6/7] update --- tests/test_frame.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_frame.py b/tests/test_frame.py index 140ffe724..7d595cdca 100644 --- a/tests/test_frame.py +++ b/tests/test_frame.py @@ -1920,4 +1920,4 @@ def f(s: pd.DataFrame) -> pd.Series: def df_accepting_dicts_iterator() -> None: # GH 392 data = [{"a": 1, "b": 2}, {"a": 3, "b": 5}] - p = pd.DataFrame(iter(data)) + check(assert_type(pd.DataFrame(iter(data)), pd.DataFrame), pd.DataFrame) From e61a894c4a8416b35beb5f4e270cf80bf156d989 Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Tue, 1 Nov 2022 02:38:56 +0530 Subject: [PATCH 7/7] update --- tests/test_frame.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_frame.py b/tests/test_frame.py index 7d595cdca..d43f2e283 100644 --- a/tests/test_frame.py +++ b/tests/test_frame.py @@ -1917,7 +1917,7 @@ def f(s: pd.DataFrame) -> pd.Series: check(assert_type(resampler.apply(f), Union[pd.Series, pd.DataFrame]), pd.DataFrame) -def df_accepting_dicts_iterator() -> None: +def df_accepting_dicts_iterator() -> None: # GH 392 data = [{"a": 1, "b": 2}, {"a": 3, "b": 5}] check(assert_type(pd.DataFrame(iter(data)), pd.DataFrame), pd.DataFrame)