[meta] migrate to 2024 edition #9398
Conversation
Created using spr 1.3.6-beta.1
|
|
||
| // Snapshots | ||
| fn format_snapshot(state: &SnapshotState) -> impl Display { | ||
| fn format_snapshot(state: &SnapshotState) -> impl Display + use<> { |
There was a problem hiding this comment.
This looks strange! Just making sure I understand: if we didn't have + use<> here, Rust 2024 would infer that the impl Display we're returning is tied to the &SnapshotState lifetime, but because we say use<>, we're explicitly saying that we're returning a type that doesn't?
Which one did Rust 2021 infer?
There was a problem hiding this comment.
Ah this specific one was added automatically and doesn't end up being strictly required, but in general yeah, in Rust 2021 the output wouldn't be tied to state's lifetime, but in Rust 2024 it is tied to that lifetime by default.
| ) -> Result<impl ExactSizeIterator<Item = DeliveryAndEvent> + 'static, Error> | ||
| { | ||
| ) -> Result< | ||
| impl ExactSizeIterator<Item = DeliveryAndEvent> + 'static + use<>, |
There was a problem hiding this comment.
Does 'static not already imply use<>?
There was a problem hiding this comment.
Good question -- I think the 'static isn't used as part of reasoning like that to keep the rules simpler. Note that this was automatically added by cargo fix --edition.
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Did this by:
cargo fix --editionmatchtoif letDue to drop order changes outlined here and here, this change is not as risk-free as I would like (potentially causing future cancellation issues, or maybe resolving latent ones). But hopefully a full release cycle would be enough time to bake these changes.