Log level mismatch in LdapFilterPlugin.java

[yiming-tang-cs]

In the example below, line 92 uses a log level of FINER in a logging statement that describes a failure that happens under a certain condition. In contrast, line 99 contains an informational log but has the same level of FINER. This contrast in severity is pronounced by the high-level exception thrown on line 96. Should the level in line 92 be greater than FINER?

opengrok/plugins/src/opengrok/auth/plugin/LdapFilterPlugin.java

Lines 90 to 99 in 9ce52a2

	try {
	if ((records = getLdapProvider().lookupLdapContent(null, expandedFilter, dn)) == null) {
	LOGGER.log(Level.FINER, "failed to get content for user from LDAP server");
	return;
	}
	} catch (LdapException ex) {
	throw new AuthorizationException(ex);
	}
	LOGGER.log(Level.FINER, "got {0} records", records.size());

Filed in conjunction with @orenwf and @khatchad.

[vladak]

Definitely, the log levels in authorization plugins are not very consistent in general.