Skip to content

Commit 09eefba

Browse files
kassifarelkorchi
authored andcommitted
[GR-54053] Backport to 24.0: Re-enable jdk-latest jobs on darwin-amd64 and move to macOS BigSur.
PullRequest: js/3165
2 parents 7d4bf7c + d752a38 commit 09eefba

File tree

7 files changed

+6
-164
lines changed

7 files changed

+6
-164
lines changed

ci.jsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ local graalNodeJs = import 'graal-nodejs/ci.jsonnet';
9696
common.jdk21 + common.windows_amd64,
9797
common.jdklatest + common.linux_amd64,
9898
common.jdklatest + common.linux_aarch64,
99-
#common.jdklatest + common.darwin_amd64, # GR-50122
99+
common.jdklatest + common.darwin_amd64,
100100
common.jdklatest + common.darwin_aarch64,
101101
common.jdklatest + common.windows_amd64,
102102
],

common.jsonnet

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,9 @@ targets +
7474

7575
darwin_amd64:: common.darwin_amd64 + self.darwin_common + {
7676
environment+: {
77-
// for compatibility with macOS High Sierra
78-
MACOSX_DEPLOYMENT_TARGET: '10.13',
77+
// for compatibility with macOS BigSur
78+
MACOSX_DEPLOYMENT_TARGET: '11.0',
7979
},
80-
capabilities+: ['darwin_mojave'],
8180
},
8281

8382
darwin_aarch64:: common.darwin_aarch64 + self.darwin_common + {

graal-js/ci.jsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ local ci = import '../ci.jsonnet';
131131
promoteToTarget(common.gate, [common.jdklatest + common.linux_amd64, common.jdklatest + common.linux_aarch64, common.jdklatest + common.windows_amd64]),
132132
graalJs + gateTags('default') + ee + {name: 'default-ee'} +
133133
promoteToTarget(common.gate, [common.jdklatest + common.linux_amd64, common.jdklatest + common.darwin_aarch64]) +
134-
promoteToTarget(common.postMerge, [common.jdk21 + common.darwin_amd64]),
134+
promoteToTarget(common.postMerge, [common.jdklatest + common.darwin_amd64]),
135135

136136
graalJs + gateTags('noic') + {name: 'noic'} + gateOnMain,
137137
graalJs + gateTags('directbytebuffer') + {name: 'directbytebuffer'} + gateOnMain,

graal-nodejs/ci.jsonnet

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,12 @@ local cicommon = import '../ci/common.jsonnet';
152152
local testingBuilds = generateBuilds([
153153
graalNodeJs + build + defaultGateTags + {dynamicimports+:: ['/wasm']} + {name: 'default'} +
154154
promoteToTarget(common.gate, [common.jdklatest + common.linux_amd64, common.jdklatest + common.linux_aarch64, common.jdklatest + common.darwin_aarch64, common.jdklatest + common.windows_amd64]) +
155-
promoteToTarget(common.postMerge, [common.jdk21 + common.darwin_amd64]),
155+
promoteToTarget(common.postMerge, [common.jdklatest + common.darwin_amd64]),
156156

157157
graalNodeJs + vm_env + build + gateVmSmokeTest + ce + {name: 'graalvm-ce'} +
158158
promoteToTarget(common.gate, [ci.mainGatePlatform]) +
159159
promoteToTarget(common.gate, [common.jdklatest + common.darwin_aarch64, common.jdklatest + common.windows_amd64]) +
160-
promoteToTarget(common.postMerge, [common.jdk21 + common.darwin_amd64]),
160+
promoteToTarget(common.postMerge, [common.jdklatest + common.darwin_amd64]),
161161
graalNodeJs + vm_env + build + gateVmSmokeTest + ee + {name: 'graalvm-ee'} +
162162
promoteToTarget(common.gate, [ci.mainGatePlatform]),
163163

graal-nodejs/deps/ada/ada.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10422,11 +10422,7 @@ ada_warn_unused std::string to_string(ada::encoding_type type) {
1042210422
/* begin file src/helpers.cpp */
1042310423

1042410424
#include <algorithm>
10425-
#if __has_include(<charconv>) && (!defined(__MAC_OS_X_VERSION_MIN_REQUIRED) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500)
1042610425
#include <charconv>
10427-
#else
10428-
#include "charconv_shim.h"
10429-
#endif
1043010426
#include <cstring>
1043110427
#include <sstream>
1043210428

graal-nodejs/deps/ada/ada.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5064,11 +5064,7 @@ ada_really_inline constexpr bool verify_dns_length(
50645064

50655065

50665066
#include <algorithm>
5067-
#if __has_include(<charconv>) && (!defined(__MAC_OS_X_VERSION_MIN_REQUIRED) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500)
50685067
#include <charconv>
5069-
#else
5070-
#include "charconv_shim.h"
5071-
#endif
50725068
#include <iostream>
50735069
#include <optional>
50745070
#include <string>

graal-nodejs/deps/ada/charconv_shim.h

Lines changed: 0 additions & 149 deletions
This file was deleted.

0 commit comments

Comments
 (0)