From 8632195fffebe54da300c31b654ca161e6de19cc Mon Sep 17 00:00:00 2001 From: Jae Kim Date: Mon, 20 Sep 2021 10:11:33 -0700 Subject: [PATCH 1/2] clean up datafile revision log --- .../optimizely/ab/config/PollingProjectConfigManager.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/core-api/src/main/java/com/optimizely/ab/config/PollingProjectConfigManager.java b/core-api/src/main/java/com/optimizely/ab/config/PollingProjectConfigManager.java index 0208d2986..b5c0a25f1 100644 --- a/core-api/src/main/java/com/optimizely/ab/config/PollingProjectConfigManager.java +++ b/core-api/src/main/java/com/optimizely/ab/config/PollingProjectConfigManager.java @@ -100,7 +100,11 @@ void setConfig(ProjectConfig projectConfig) { return; } - logger.info("New datafile set with revision: {}. Old revision: {}", projectConfig.getRevision(), previousRevision); + if (previousRevision == null) { + logger.info("New datafile set with revision: {}.", projectConfig.getRevision()); + } else { + logger.info("New datafile set with revision: {}. Old revision: {}", projectConfig.getRevision(), previousRevision); + } currentProjectConfig.set(projectConfig); currentOptimizelyConfig.set(new OptimizelyConfigService(projectConfig).getConfig()); From 105012bfbd7d4e36d718ef331cd83a9ad66ac357 Mon Sep 17 00:00:00 2001 From: Jae Kim Date: Mon, 20 Sep 2021 10:16:26 -0700 Subject: [PATCH 2/2] fix datafile revision log --- .../com/optimizely/ab/config/PollingProjectConfigManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core-api/src/main/java/com/optimizely/ab/config/PollingProjectConfigManager.java b/core-api/src/main/java/com/optimizely/ab/config/PollingProjectConfigManager.java index b5c0a25f1..b03aeabc0 100644 --- a/core-api/src/main/java/com/optimizely/ab/config/PollingProjectConfigManager.java +++ b/core-api/src/main/java/com/optimizely/ab/config/PollingProjectConfigManager.java @@ -100,7 +100,7 @@ void setConfig(ProjectConfig projectConfig) { return; } - if (previousRevision == null) { + if (oldProjectConfig == null) { logger.info("New datafile set with revision: {}.", projectConfig.getRevision()); } else { logger.info("New datafile set with revision: {}. Old revision: {}", projectConfig.getRevision(), previousRevision);