Fix a bug in olm install

When installing OLM, retry creating resources, if the CRD is not ready
yet.

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>

Author: nunnatsa

changelog/fragments/01-olm-install-retry.yaml

@@ -0,0 +1,10 @@
+# entries is a list of entries to include in
+# release notes and/or the migration guide
+entries:
+  - description: >
+      Fix a bug where `olm install` command is failed fo "no-match" error.
+
+    kind: "bugfix"
+
+    # Is this a breaking change?
+    breaking: false

internal/olm/client/client.go

@@ -113,17 +113,44 @@ func (c Client) DoCreate(ctx context.Context, objs ...client.Object) error {
 	for _, obj := range objs {
 		kind := obj.GetObjectKind().GroupVersionKind().Kind
 		log.Infof("  Creating %s %q", kind, getName(obj.GetNamespace(), obj.GetName()))
-		err := c.KubeClient.Create(ctx, obj)
-		if err != nil {
-			if !apierrors.IsAlreadyExists(err) {
+
+		for i := 0; i < 5; i++ { // try to create 5 times before giving up
+			retry, err := c.tryCreatingOneResource(ctx, obj, kind)
+			if err != nil {
 				return err
 			}
-			log.Infof("    %s %q already exists", kind, getName(obj.GetNamespace(), obj.GetName()))
+
+			if retry {
+				log.Infof("    the CRD for %s %q is not ready yet. Retrying in one second", kind, getName(obj.GetNamespace(), obj.GetName()))
+				time.Sleep(time.Second)
+				continue
+			}
+
+			log.Infof("    %s %q created", kind, getName(obj.GetNamespace(), obj.GetName()))
+			break
 		}
 	}
 	return nil
 }
 
+func (c Client) tryCreatingOneResource(ctx context.Context, obj client.Object, kind string) (bool, error) {
+	err := c.KubeClient.Create(ctx, obj)
+	if err != nil {
+		if apierrors.IsAlreadyExists(err) {
+			log.Infof("    %s %q already exists", kind, getName(obj.GetNamespace(), obj.GetName()))
+			return false, nil
+		}
+
+		if meta.IsNoMatchError(err) {
+			return true, nil
+		}
+
+		return false, err
+	}
+
+	return false, nil
+}
+
 func (c Client) DoDelete(ctx context.Context, objs ...client.Object) error {
 	for _, obj := range objs {
 		kind := obj.GetObjectKind().GroupVersionKind().Kind