hack/tests/scaffolding: remove unused var and add TODOs

Author: AlexNPavel

hack/tests/scaffolding/e2e-go-scaffold.sh

@@ -5,10 +5,8 @@ set -ex
 source hack/lib/test_lib.sh
 
 ROOTDIR="$(pwd)"
-trap_add 'rm $ROOTDIR/go.mod || true' EXIT
-GOTMP="$(mktemp -d)"
-trap_add 'rm -rf $GOTMP' EXIT
-BASEPROJECTDIR="/tmp/go-e2e-scaffold"
+# TODO: remove once PR 1566 is merged
+trap_add 'rm -f $ROOTDIR/go.mod' EXIT
 IMAGE_NAME="quay.io/example/memcached-operator:v0.0.1"
 
 rm -rf $BASEPROJECTDIR

hack/tests/scaffolding/scaffold-memcached.go

@@ -77,6 +77,7 @@ func main() {
 
 	replace := getGoModReplace(localSDKPath)
 	if replace.repo != sdkRepo {
+		// TODO: Remove when PR 1566 is merged
 		if replace.isLocal {
 			// A hacky way to get local module substitution to work is to write a
 			// stub go.mod into the local SDK repo referred to in