Skip to content

Commit 8bab1f9

Browse files
committed
addressing PR comments
1 parent f7a4545 commit 8bab1f9

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ build: ## Build operator-sdk, ansible-operator, and helm-operator.
5151

5252
.PHONY: install
5353
GOBIN ?= $(shell go env GOPATH)/bin
54-
install: build ## Install operator-sdk, ansible-operator, and helm-operator in $GOBIN
55-
install -t $(GOBIN) $(BUILD_DIR)/{operator-sdk,ansible-operator,helm-operator}
54+
install: ## Install operator-sdk, ansible-operator, and helm-operator in $GOBIN
55+
go install $(GO_BUILD_ARGS) ./cmd/{operator-sdk,ansible-operator,helm-operator}
5656

5757
.PHONY: image-build-sdk image-push-sdk image-push-sdk-multiarch
5858
OPERATOR_SDK_CI_IMAGE = quay.io/operator-framework/operator-sdk
@@ -152,8 +152,8 @@ export KUBECONFIG := $(HOME)/.kube/kind-$(KIND_CLUSTER).config
152152
export KUBEBUILDER_ASSETS := $(PWD)/tools/bin
153153
test-e2e-setup: build
154154
./tools/scripts/fetch kind 0.9.0
155-
./tools/scripts/fetch kubectl ${K8S_VERSION}
156155
./tools/scripts/fetch envtest 0.6.3
156+
./tools/scripts/fetch kubectl ${K8S_VERSION} # Install kubectl AFTER envtest because envtest includes its own kubectl binary
157157
[[ "`./tools/bin/kind get clusters`" =~ "$(KIND_CLUSTER)" ]] || ./tools/bin/kind create cluster --image="kindest/node:v$(K8S_VERSION)" --name $(KIND_CLUSTER)
158158

159159
.PHONY: test-e2e-teardown

internal/testutils/utils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ func ReplaceRegexInFile(path, match, replace string) error {
123123
return nil
124124
}
125125

126-
// LoadImageToKindCluster loads a local docker image with the name informed to the kind cluster
126+
// LoadImageToKindClusterWithName loads a local docker image with the name informed to the kind cluster
127127
func (tc TestContext) LoadImageToKindClusterWithName(image string) error {
128128
cluster := "kind"
129129
if v, ok := os.LookupEnv("KIND_CLUSTER"); ok {

0 commit comments

Comments
 (0)