-
Notifications
You must be signed in to change notification settings - Fork 68
✨ OPRUN-4240: Add Claude Code integration for test profiling #2309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2309 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 91 91
Lines 7057 7057
==========================================
- Hits 5252 5241 -11
- Misses 1393 1402 +9
- Partials 412 414 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is something we should discuss before merging.
Personally, I’d prefer that we keep our instructions AI-agnostic, rather than tied to a specific vendor or model like Claude.
For example, instead of adding a CLAUDE.md, we could introduce something like an AGENTS.md file that describes generic AI/agent usage and workflows. Then, if needed, we could create aliases or vendor-specific adapters for Claude, ChatGPT, etc. — without locking ourselves to one ecosystem.
Also, just to confirm: can every contributor actually use Claude?
Do all contributors have access to it without a paid plan?
If not, that might make a vendor-specific setup harder to maintain or may exclude contributors unintentionally.
|
/hold |
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the discussion: https://kubernetes.slack.com/archives/C04066HP28K/p1762846782356659?thread_ts=1762534450.554899&cid=C04066HP28K
I think we can move forward and after we see if we can make it work with others AI toolings as well.
d2ae505 to
d58e2d1
Compare
|
/unhold |
.claude/commands/test-profile.md
Outdated
|
|
||
| - kubectl access to cluster | ||
| - go tool pprof (for analysis) | ||
| - Go 1.22+ (for building) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmshort ^ is that true
How will we keep it updated?
Should not minimal go requirement same of go.mod ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to be a reference to the appropriate go.mod
Add `/test-profile` slash command to enable interactive profiling workflow through Claude Code interface with the Go-based test profiling tools. The command provides access to: - start/stop: Background profiling daemon workflow - run: Automated test execution with profiling - analyze: Generate analysis reports from collected profiles - compare: Compare two test runs side-by-side - collect: One-time profile snapshots Documentation includes configuration, output structure, and implementation steps for the Go-based CLI tool located in hack/tools/test-profiling/. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Todd Short <[email protected]>
d58e2d1 to
fb21aa5
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Great 👍 It is amazing see our first command instruction 🎉 |
Add
/test-profileslash command to enable interactive profiling workflow through Claude Code interface.Follow-on to #2298
🤖 Generated with Claude Code
Description
Reviewer Checklist