Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Nov 5, 2025

Add /test-profile slash command to enable interactive profiling workflow through Claude Code interface.

Follow-on to #2298

🤖 Generated with Claude Code

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner November 5, 2025 18:45
@openshift-ci openshift-ci bot requested review from OchiengEd and grokspawn November 5, 2025 18:45
@netlify
Copy link

netlify bot commented Nov 5, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit fb21aa5
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6914d5107322460008fec9a5
😎 Deploy Preview https://deploy-preview-2309--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.26%. Comparing base (d204888) to head (fb21aa5).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2309      +/-   ##
==========================================
- Coverage   74.42%   74.26%   -0.16%     
==========================================
  Files          91       91              
  Lines        7057     7057              
==========================================
- Hits         5252     5241      -11     
- Misses       1393     1402       +9     
- Partials      412      414       +2     
Flag Coverage Δ
e2e 45.83% <ø> (-0.04%) ⬇️
experimental-e2e 48.23% <ø> (-0.22%) ⬇️
unit 58.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is something we should discuss before merging.
Personally, I’d prefer that we keep our instructions AI-agnostic, rather than tied to a specific vendor or model like Claude.

For example, instead of adding a CLAUDE.md, we could introduce something like an AGENTS.md file that describes generic AI/agent usage and workflows. Then, if needed, we could create aliases or vendor-specific adapters for Claude, ChatGPT, etc. — without locking ourselves to one ecosystem.

Also, just to confirm: can every contributor actually use Claude?
Do all contributors have access to it without a paid plan?
If not, that might make a vendor-specific setup harder to maintain or may exclude contributors unintentionally.

@tmshort
Copy link
Contributor Author

tmshort commented Nov 7, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2025
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the discussion: https://kubernetes.slack.com/archives/C04066HP28K/p1762846782356659?thread_ts=1762534450.554899&cid=C04066HP28K

I think we can move forward and after we see if we can make it work with others AI toolings as well.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@tmshort tmshort force-pushed the claude-memory-profiling branch from d2ae505 to d58e2d1 Compare November 11, 2025 14:21
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Nov 11, 2025

/unhold
Based on the slack thread.
I have also updated this to be more precise. @camilamacedo86

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2025
@tmshort tmshort changed the title ✨ OPRUN-4240: Add Claude Code integration for e2e profiling ✨ OPRUN-4240: Add Claude Code integration for test profiling Nov 11, 2025

- kubectl access to cluster
- go tool pprof (for analysis)
- Go 1.22+ (for building)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmshort ^ is that true
How will we keep it updated?
Should not minimal go requirement same of go.mod ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to be a reference to the appropriate go.mod

Add `/test-profile` slash command to enable interactive profiling workflow
through Claude Code interface with the Go-based test profiling tools.

The command provides access to:
- start/stop: Background profiling daemon workflow
- run: Automated test execution with profiling
- analyze: Generate analysis reports from collected profiles
- compare: Compare two test runs side-by-side
- collect: One-time profile snapshots

Documentation includes configuration, output structure, and implementation
steps for the Go-based CLI tool located in hack/tools/test-profiling/.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort force-pushed the claude-memory-profiling branch from d58e2d1 to fb21aa5 Compare November 12, 2025 18:42
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Contributor

Great 👍
I think it is fine we can improve in the long run as well.

It is amazing see our first command instruction 🎉
Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants