Skip to content

Use k8s.io/apimachinery/pkg/util/sets package #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmshort opened this issue May 21, 2024 · 1 comment · Fixed by #933
Closed

Use k8s.io/apimachinery/pkg/util/sets package #881

tmshort opened this issue May 21, 2024 · 1 comment · Fixed by #933
Assignees
@itroyano

Comments

@tmshort
Copy link
Contributor

tmshort commented May 21, 2024 

          Nit: I personally love using maps with empty value for sets, but I previously received feedback suggesting to use `sets` package (`k8s.io/apimachinery/pkg/util/sets`).

Originally posted by @m1kola in #846 (comment)
@tmshort tmshort mentioned this issue May 21, 2024
Merged
4 tasks
@varshaprasad96 varshaprasad96 mentioned this issue May 31, 2024
Closed
11 tasks
@itroyano
Copy link
Contributor

/assign

@itroyano itroyano mentioned this issue Jun 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itroyano itroyano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Use apimachinery sets instead of maps itroyano/operator-controller
2 participants
@tmshort @itroyano