Skip to content

Create an interface to Deppy that encapsulates the necessary solver methods #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awgreene opened this issue Dec 7, 2022 · 1 comment
Assignees

Comments

@awgreene
Copy link
Member

awgreene commented Dec 7, 2022

User Story:

  • As a developer on the Operator Controller project, I would like to place any calls to Deppy solver behind a reasonable interface so I can easily test or swap out the Deppy implementation.

Background:

  • The Deppy project is being developed as a library that third party projects may utilize.
  • There is a possibility that the Operator Controller will need to introduce an Kubernetes Native API (a CRD) that will allow users to configure constraints sent to the resolver.
  • To support the possible change, calls to the Deppy Solver should be be done through an interface.
  • Placing the Solver behind an interface will simplify unit testing as well.
  • The existing solver interface can be found here.

Acceptance Criteria:

  • The Deppy Solver is implemented using an interface
@perdasilva
Copy link
Contributor

https://github.com/operator-framework/operator-controller/blob/main/internal/resolution/resolver.go is nearly there. I think we should just refactor to remove the entitySource parameter and create that internally in the resolver.

@awgreene awgreene moved this from Todo to In Progress in OLM v1 Feb 6, 2023
@awgreene awgreene assigned awgreene and perdasilva and unassigned awgreene Feb 7, 2023
@awgreene awgreene moved this from In Progress to Done in OLM v1 Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants