Skip to content

Simplify the reasons used in status conditions to only Succeeded and Failed #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #740
everettraven opened this issue Aug 19, 2024 · 2 comments · Fixed by #1241
Closed
Tracked by #740

Simplify the reasons used in status conditions to only Succeeded and Failed #1153

everettraven opened this issue Aug 19, 2024 · 2 comments · Fixed by #1241
Assignees
Labels
epic/v1-api good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. v1.0 Issues related to the initial stable release of OLMv1
Milestone

Comments

@everettraven
Copy link
Contributor

everettraven commented Aug 19, 2024

Currently, we have a mixture of reasons used for different status condition types that are a flavor of the terms Succeeded or Failed.

For example, we have:

  • UnpackSuccess and UnpackFailed for the Unpacked condition type
  • Success and InstallationFailed for the Installed condition type
  • Success and ResolutionFailed for the Resolved condition type

As outlined in the v1 API Review RFC, we should simplify this to using Succeeded and Failed for all the status condition types (Unpacked, Installed, Resolved) to ensure consistency.

@bentito
Copy link
Contributor

bentito commented Aug 20, 2024

Can you give some more detail? Should we refer back to the RFC that is related?: https://docs.google.com/document/d/1JWJxnDXM0X1JQ67ZIDx5j1ayb1d7ajrK_uSDDaz0G98

@everettraven
Copy link
Contributor Author

@bentito I just updated the description. I created this issue as part of the v1 API review epic task list late yesterday and hadn't had a chance to finish going through and populating the issue descriptions until now :)

@everettraven everettraven added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. v1.0 Issues related to the initial stable release of OLMv1 epic/v1-api labels Aug 20, 2024
@everettraven everettraven added this to the v1.0.0 milestone Aug 20, 2024
@oceanc80 oceanc80 self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/v1-api good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. v1.0 Issues related to the initial stable release of OLMv1
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants