Improve caching and fix constant reconciles (#825)

Improve performance by caching objects that only have ClusterExtension
as owners.

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Author: varshaprasad96

cmd/manager/main.go

@@ -25,8 +25,12 @@ import (
 	"os"
 	"time"
 
+	"github.com/operator-framework/operator-controller/internal/labels"
+
 	"github.com/spf13/pflag"
 	"go.uber.org/zap/zapcore"
+	k8slabels "k8s.io/apimachinery/pkg/labels"
+	"k8s.io/apimachinery/pkg/selection"
 	_ "k8s.io/client-go/plugin/pkg/client/auth"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
@@ -39,12 +43,14 @@ import (
 	"github.com/operator-framework/rukpak/pkg/storage"
 	"github.com/operator-framework/rukpak/pkg/util"
 
+	"github.com/operator-framework/operator-controller/api/v1alpha1"
 	"github.com/operator-framework/operator-controller/internal/catalogmetadata/cache"
 	catalogclient "github.com/operator-framework/operator-controller/internal/catalogmetadata/client"
 	"github.com/operator-framework/operator-controller/internal/controllers"
 	"github.com/operator-framework/operator-controller/internal/handler"
 	"github.com/operator-framework/operator-controller/pkg/features"
 	"github.com/operator-framework/operator-controller/pkg/scheme"
+	crcache "sigs.k8s.io/controller-runtime/pkg/cache"
 )
 
 var (
@@ -83,13 +89,33 @@ func main() {
 
 	ctrl.SetLogger(zap.New(zap.UseFlagOptions(&opts), zap.StacktraceLevel(zapcore.DPanicLevel)))
 
+	if systemNamespace == "" {
+		systemNamespace = util.PodNamespace()
+	}
+
+	dependentRequirement, err := k8slabels.NewRequirement(labels.OwnerKindKey, selection.In, []string{v1alpha1.ClusterExtensionKind})
+	if err != nil {
+		setupLog.Error(err, "unable to create dependent label selector for cache")
+		os.Exit(1)
+	}
+	dependentSelector := k8slabels.NewSelector().Add(*dependentRequirement)
+
 	fmt.Println("set up manager")
 	mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
 		Scheme:                 scheme.Scheme,
 		Metrics:                server.Options{BindAddress: metricsAddr},
 		HealthProbeBindAddress: probeAddr,
 		LeaderElection:         enableLeaderElection,
 		LeaderElectionID:       "9c4404e7.operatorframework.io",
+		Cache: crcache.Options{
+			ByObject: map[client.Object]crcache.ByObject{
+				&v1alpha1.ClusterExtension{}: {},
+			},
+			DefaultNamespaces: map[string]crcache.Config{
+				systemNamespace:       {},
+				crcache.AllNamespaces: {LabelSelector: dependentSelector},
+			},
+		},
 		// LeaderElectionReleaseOnCancel defines if the leader should step down voluntarily
 		// when the Manager ends. This requires the binary to immediately end when the
 		// Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
@@ -124,10 +150,6 @@ func main() {
 		os.Exit(1)
 	}
 
-	if systemNamespace == "" {
-		systemNamespace = util.PodNamespace()
-	}
-
 	unpacker, err := source.NewDefaultUnpacker(mgr, systemNamespace, unpackImage, (*x509.CertPool)(nil))
 	if err != nil {
 		setupLog.Error(err, "unable to create unpacker")