Update fields in the spec to no longer be a pointer

Signed-off-by: Rashmi Gottipati <[email protected]>

Author: rashmigottipati

api/v1alpha1/clusterextension_types.go

@@ -265,7 +265,7 @@ type ClusterExtensionSpec struct {
 	// When not specified, the default configuration for each preflight check will be used.
 	//
 	//+optional
-	Preflight *PreflightConfig `json:"preflight,omitempty"`
+	Preflight PreflightConfig `json:"preflight,omitempty"`
 
 	// serviceAccount is a required reference to a ServiceAccount that exists
 	// in the installNamespace. The provided ServiceAccount is used to install and
@@ -319,7 +319,7 @@ type PreflightConfig struct {
 	// consequences of upgrading a CRD, such as data loss.
 	//
 	// This field is required if the spec.preflight field is specified.
-	CRDUpgradeSafety *CRDUpgradeSafetyPreflightConfig `json:"crdUpgradeSafety"`
+	CRDUpgradeSafety CRDUpgradeSafetyPreflightConfig `json:"crdUpgradeSafety"`
 }
 
 // CRDUpgradeSafetyPreflightConfig is the configuration for CRD upgrade safety preflight check.

api/v1alpha1/zz_generated.deepcopy.go

@@ -69,12 +69,11 @@ func (h *Helm) Apply(ctx context.Context, contentFS fs.FS, ext *ocv1alpha1.Clust
 	}
 
 	for _, preflight := range h.Preflights {
-		if ext.Spec.Preflight != nil && ext.Spec.Preflight.CRDUpgradeSafety != nil {
-			if _, ok := preflight.(*crdupgradesafety.Preflight); ok && ext.Spec.Preflight.CRDUpgradeSafety.Policy == ocv1alpha1.CRDUpgradeSafetyPolicyDisabled {
-				// Skip this preflight check because it is of type *crdupgradesafety.Preflight and the CRD Upgrade Safety
-				// preflight check has been disabled
-				continue
-			}
+		if _, ok := preflight.(*crdupgradesafety.Preflight); ok && ext.Spec.Preflight.CRDUpgradeSafety.Policy == ocv1alpha1.CRDUpgradeSafetyPolicyDisabled {
+			// Skip this preflight check because it is of type *crdupgradesafety.Preflight and the CRD Upgrade Safety
+			// preflight check has been disabled
+			continue
+
 		}
 		switch state {
 		case StateNeedsInstall: