Skip to content

Commit 177d840

Browse files
Fix linter
Signed-off-by: Varsha Prasad Narsing <[email protected]>
1 parent 04348ac commit 177d840

File tree

5 files changed

+5
-16
lines changed

5 files changed

+5
-16
lines changed

api/v1alpha1/clusterextension_types.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,8 @@ type ClusterExtensionStatus struct {
145145
InstalledBundle *BundleMetadata `json:"installedBundle,omitempty"`
146146
// +optional
147147
ResolvedBundle *BundleMetadata `json:"resolvedBundle,omitempty"`
148+
// +optional
149+
ContentURL string `json:"contentURL,omitempty"`
148150

149151
// +patchMergeKey=type
150152
// +patchStrategy=merge

config/crd/bases/olm.operatorframework.io_clusterextensions.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,8 @@ spec:
151151
x-kubernetes-list-map-keys:
152152
- type
153153
x-kubernetes-list-type: map
154+
contentURL:
155+
type: string
154156
installedBundle:
155157
properties:
156158
name:

internal/controllers/clusterextension_controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,6 @@ func (r *ClusterExtensionReconciler) resolve(ctx context.Context, clusterExtensi
604604
return nil, err
605605
}
606606
predicates = append(predicates, catalogfilter.InMastermindsSemverRange(wantedVersionRangeConstraint))
607-
608607
}
609608
}
610609

internal/controllers/clusterextension_status.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,7 @@ func updateStatusUnpacking(status *ocv1alpha1.ClusterExtensionStatus, result *so
6262
}
6363

6464
func updateStatusUnpacked(status *ocv1alpha1.ClusterExtensionStatus, result *source.Result, contentURL string) {
65-
// TODO: Expose content URL through CE status.
66-
status.ResolvedBundle = &ocv1alpha1.BundleMetadata{
67-
Name: result.ResolvedSource.Image.Ref,
68-
}
65+
status.ContentURL = contentURL
6966
meta.SetStatusCondition(&status.Conditions, metav1.Condition{
7067
Type: rukpakapi.TypeUnpacked,
7168
Status: metav1.ConditionTrue,

internal/controllers/common_controller.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -43,17 +43,6 @@ func setResolvedStatusConditionSuccess(conditions *[]metav1.Condition, message s
4343
})
4444
}
4545

46-
// setInstalledStatusConditionUnknown sets the installed status condition to unknown.
47-
func setInstalledStatusConditionUnknown(conditions *[]metav1.Condition, message string, generation int64) {
48-
apimeta.SetStatusCondition(conditions, metav1.Condition{
49-
Type: ocv1alpha1.TypeInstalled,
50-
Status: metav1.ConditionUnknown,
51-
Reason: ocv1alpha1.ReasonInstallationStatusUnknown,
52-
Message: message,
53-
ObservedGeneration: generation,
54-
})
55-
}
56-
5746
// setResolvedStatusConditionFailed sets the resolved status condition to failed.
5847
func setResolvedStatusConditionFailed(conditions *[]metav1.Condition, message string, generation int64) {
5948
apimeta.SetStatusCondition(conditions, metav1.Condition{

0 commit comments

Comments
 (0)