naming

Signed-off-by: Attila Mészáros <[email protected]>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java

@@ -304,8 +304,8 @@ private <P extends HasMetadata> ResolvedControllerConfiguration<P> controllerCon
     final var dependentFieldManager =
         fieldManager.equals(CONTROLLER_NAME_AS_FIELD_MANAGER) ? name : fieldManager;
 
-    var propagateAllEventToReconciler =
-        annotation != null && annotation.propagateAllEventToReconciler();
+    var triggerReconcilerOnAllEvent =
+        annotation != null && annotation.triggerReconcilerOnAllEvent();
 
     InformerConfiguration<P> informerConfig =
         InformerConfiguration.builder(resourceClass)
@@ -327,7 +327,7 @@ private <P extends HasMetadata> ResolvedControllerConfiguration<P> controllerCon
         dependentFieldManager,
         this,
         informerConfig,
-        propagateAllEventToReconciler);
+        triggerReconcilerOnAllEvent);
   }
 
   /**

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfiguration.java

@@ -93,7 +93,7 @@ default String fieldManager() {
 
   <C> C getConfigurationFor(DependentResourceSpec<?, P, C> spec);
 
-  default boolean propagateAllEventToReconciler() {
+  default boolean triggerReconcilerOnAllEvent() {
     return false;
   }
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfigurationOverrider.java

@@ -30,7 +30,7 @@ public class ControllerConfigurationOverrider<R extends HasMetadata> {
   private Duration reconciliationMaxInterval;
   private Map<DependentResourceSpec, Object> configurations;
   private final InformerConfiguration<R>.Builder config;
-  private boolean propagateAllEventToReconciler;
+  private boolean triggerReconcilerOnAllEvent;
 
   private ControllerConfigurationOverrider(ControllerConfiguration<R> original) {
     this.finalizer = original.getFinalizerName();
@@ -43,7 +43,7 @@ private ControllerConfigurationOverrider(ControllerConfiguration<R> original) {
     this.rateLimiter = original.getRateLimiter();
     this.name = original.getName();
     this.fieldManager = original.fieldManager();
-    this.propagateAllEventToReconciler = original.propagateAllEventToReconciler();
+    this.triggerReconcilerOnAllEvent = original.triggerReconcilerOnAllEvent();
   }
 
   public ControllerConfigurationOverrider<R> withFinalizer(String finalizer) {
@@ -156,9 +156,9 @@ public ControllerConfigurationOverrider<R> withFieldManager(String dependentFiel
     return this;
   }
 
-  public ControllerConfigurationOverrider<R> withPropagateAllEventToReconciler(
-      boolean propagateAllEventToReconciler) {
-    this.propagateAllEventToReconciler = propagateAllEventToReconciler;
+  public ControllerConfigurationOverrider<R> withTriggerReconcilerOnAllEvent(
+      boolean triggerReconcilerOnAllEvent) {
+    this.triggerReconcilerOnAllEvent = triggerReconcilerOnAllEvent;
     return this;
   }
 
@@ -206,7 +206,7 @@ public ControllerConfiguration<R> build() {
         fieldManager,
         original.getConfigurationService(),
         config.buildForController(),
-        propagateAllEventToReconciler,
+        triggerReconcilerOnAllEvent,
         original.getWorkflowSpec().orElse(null));
   }
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ResolvedControllerConfiguration.java

@@ -29,7 +29,7 @@ public class ResolvedControllerConfiguration<P extends HasMetadata>
   private final Map<DependentResourceSpec, Object> configurations;
   private final ConfigurationService configurationService;
   private final String fieldManager;
-  private final boolean propagateAllEventToReconciler;
+  private final boolean triggerReconcilerOnAllEvent;
   private WorkflowSpec workflowSpec;
 
   public ResolvedControllerConfiguration(ControllerConfiguration<P> other) {
@@ -45,7 +45,7 @@ public ResolvedControllerConfiguration(ControllerConfiguration<P> other) {
         other.fieldManager(),
         other.getConfigurationService(),
         other.getInformerConfig(),
-        other.propagateAllEventToReconciler(),
+        other.triggerReconcilerOnAllEvent(),
         other.getWorkflowSpec().orElse(null));
   }
 
@@ -61,7 +61,7 @@ public ResolvedControllerConfiguration(
       String fieldManager,
       ConfigurationService configurationService,
       InformerConfiguration<P> informerConfig,
-      boolean propagateAllEventToReconciler,
+      boolean triggerReconcilerOnAllEvent,
       WorkflowSpec workflowSpec) {
     this(
         name,
@@ -75,7 +75,7 @@ public ResolvedControllerConfiguration(
         fieldManager,
         configurationService,
         informerConfig,
-        propagateAllEventToReconciler);
+        triggerReconcilerOnAllEvent);
     setWorkflowSpec(workflowSpec);
   }
 
@@ -91,7 +91,7 @@ protected ResolvedControllerConfiguration(
       String fieldManager,
       ConfigurationService configurationService,
       InformerConfiguration<P> informerConfig,
-      boolean propagateAllEventToReconciler) {
+      boolean triggerReconcilerOnAllEvent) {
     this.informerConfig = informerConfig;
     this.configurationService = configurationService;
     this.name = ControllerConfiguration.ensureValidName(name, associatedReconcilerClassName);
@@ -104,7 +104,7 @@ protected ResolvedControllerConfiguration(
     this.finalizer =
         ControllerConfiguration.ensureValidFinalizerName(finalizer, getResourceTypeName());
     this.fieldManager = fieldManager;
-    this.propagateAllEventToReconciler = propagateAllEventToReconciler;
+    this.triggerReconcilerOnAllEvent = triggerReconcilerOnAllEvent;
   }
 
   protected ResolvedControllerConfiguration(
@@ -216,7 +216,7 @@ public String fieldManager() {
   }
 
   @Override
-  public boolean propagateAllEventToReconciler() {
-    return ControllerConfiguration.super.propagateAllEventToReconciler();
+  public boolean triggerReconcilerOnAllEvent() {
+    return triggerReconcilerOnAllEvent;
   }
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java

@@ -78,5 +78,5 @@ MaxReconciliationInterval maxReconciliationInterval() default
    */
   String fieldManager() default CONTROLLER_NAME_AS_FIELD_MANAGER;
 
-  boolean propagateAllEventToReconciler() default false;
+  boolean triggerReconcilerOnAllEvent() default false;
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventProcessor.java

@@ -548,6 +548,6 @@ public synchronized boolean isRunning() {
 
   // shortening
   private boolean propagateAllEvent() {
-    return controllerConfiguration.propagateAllEventToReconciler();
+    return controllerConfiguration.triggerReconcilerOnAllEvent();
   }
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java

@@ -536,6 +536,6 @@ private Resource<R> resource(R resource) {
   }
 
   private boolean propagateAllEvent() {
-    return configuration().propagateAllEventToReconciler();
+    return configuration().triggerReconcilerOnAllEvent();
   }
 }

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/propagateallevent/onlyreconcile/PropagateEventReconciler.java

@@ -11,9 +11,7 @@
 import io.javaoperatorsdk.operator.api.reconciler.Reconciler;
 import io.javaoperatorsdk.operator.api.reconciler.UpdateControl;
 
-@ControllerConfiguration(
-    propagateAllEventToReconciler = true,
-    generationAwareEventProcessing = false)
+@ControllerConfiguration(triggerReconcilerOnAllEvent = true, generationAwareEventProcessing = false)
 public class PropagateEventReconciler implements Reconciler<PropagateAllEventCustomResource> {
 
   private static final Logger log = LoggerFactory.getLogger(PropagateEventReconciler.class);