Skip to content

Commit d9b08ab

Browse files
committed
IT fix
1 parent b275b0d commit d9b08ab

File tree

2 files changed

+27
-26
lines changed

2 files changed

+27
-26
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java

+8-9
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,14 @@ private void configureWith(String labelSelector, Set<String> namespaces,
6767
namespaces = context.getControllerConfiguration().getNamespaces();
6868
}
6969

70-
if (eventSource() == null) {
71-
var ic = InformerConfiguration.from(resourceType())
72-
.withLabelSelector(labelSelector)
73-
.withSecondaryToPrimaryMapper(getSecondaryToPrimaryMapper())
74-
.withNamespaces(namespaces, inheritNamespacesOnChange)
75-
.build();
76-
77-
configureWith(new InformerEventSource<>(ic, context));
78-
}
70+
var ic = InformerConfiguration.from(resourceType())
71+
.withLabelSelector(labelSelector)
72+
.withSecondaryToPrimaryMapper(getSecondaryToPrimaryMapper())
73+
.withNamespaces(namespaces, inheritNamespacesOnChange)
74+
.build();
75+
76+
configureWith(new InformerEventSource<>(ic, context));
77+
7978
}
8079

8180
@SuppressWarnings("unchecked")

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multipledependentresource/MultipleDependentResourceReconciler.java

+19-17
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@
55

66
import io.fabric8.kubernetes.api.model.ConfigMap;
77
import io.fabric8.kubernetes.client.KubernetesClient;
8+
import io.javaoperatorsdk.operator.api.config.informer.InformerConfiguration;
89
import io.javaoperatorsdk.operator.api.reconciler.*;
910
import io.javaoperatorsdk.operator.junit.KubernetesClientAware;
10-
import io.javaoperatorsdk.operator.processing.dependent.kubernetes.KubernetesDependentResourceConfig;
1111
import io.javaoperatorsdk.operator.processing.event.ResourceID;
1212
import io.javaoperatorsdk.operator.processing.event.source.EventSource;
13+
import io.javaoperatorsdk.operator.processing.event.source.informer.InformerEventSource;
1314
import io.javaoperatorsdk.operator.support.TestExecutionInfoProvider;
1415

1516
@ControllerConfiguration
@@ -31,19 +32,16 @@ public MultipleDependentResourceReconciler() {
3132

3233
secondDependentResourceConfigMap = new MultipleDependentResourceConfigMap(SECOND_CONFIG_MAP_ID);
3334

34-
firstDependentResourceConfigMap.configureWith(
35-
new KubernetesDependentResourceConfig()
36-
.setResourceDiscriminator(
37-
new ResourceIDMatcherDiscriminator<ConfigMap, MultipleDependentResourceCustomResource>(
38-
p -> new ResourceID(p.getConfigMapName(FIRST_CONFIG_MAP_ID),
39-
p.getMetadata().getNamespace()))));
40-
41-
secondDependentResourceConfigMap.configureWith(
42-
new KubernetesDependentResourceConfig()
43-
.setResourceDiscriminator(
44-
new ResourceIDMatcherDiscriminator<ConfigMap, MultipleDependentResourceCustomResource>(
45-
p -> new ResourceID(p.getConfigMapName(SECOND_CONFIG_MAP_ID),
46-
p.getMetadata().getNamespace()))));
35+
firstDependentResourceConfigMap
36+
.setResourceDiscriminator(
37+
new ResourceIDMatcherDiscriminator<>(
38+
p -> new ResourceID(p.getConfigMapName(FIRST_CONFIG_MAP_ID),
39+
p.getMetadata().getNamespace())));
40+
secondDependentResourceConfigMap
41+
.setResourceDiscriminator(
42+
new ResourceIDMatcherDiscriminator<>(
43+
p -> new ResourceID(p.getConfigMapName(SECOND_CONFIG_MAP_ID),
44+
p.getMetadata().getNamespace())));
4745
}
4846

4947
@Override
@@ -64,9 +62,13 @@ public int getNumberOfExecutions() {
6462
@Override
6563
public Map<String, EventSource> prepareEventSources(
6664
EventSourceContext<MultipleDependentResourceCustomResource> context) {
67-
return EventSourceInitializer.nameEventSources(
68-
firstDependentResourceConfigMap.initEventSource(context),
69-
secondDependentResourceConfigMap.initEventSource(context));
65+
InformerEventSource<ConfigMap, MultipleDependentResourceCustomResource> eventSource =
66+
new InformerEventSource<>(InformerConfiguration.from(ConfigMap.class, context)
67+
.build(), context);
68+
firstDependentResourceConfigMap.configureWith(eventSource);
69+
secondDependentResourceConfigMap.configureWith(eventSource);
70+
71+
return EventSourceInitializer.nameEventSources(eventSource);
7072
}
7173

7274
@Override

0 commit comments

Comments
 (0)