move checkMissingFields to its own file, as this is a general function

Author: estroz

pkg/validation/internal/csv.go

@@ -58,46 +58,6 @@ func checkFields(csv *operatorsv1alpha1.ClusterServiceVersion) (errs []errors.Er
 	return append(result.Errors, result.Warnings...)
 }
 
-// Recursive function that traverses a nested struct passed in as reflect value, and reports for errors/warnings
-// in case of null struct field values.
-func checkMissingFields(result *errors.ManifestResult, v reflect.Value, parentStructName string) {
-	if v.Kind() != reflect.Struct {
-		return
-	}
-	typ := v.Type()
-
-	for i := 0; i < v.NumField(); i++ {
-		fieldValue := v.Field(i)
-		fieldType := typ.Field(i)
-
-		tag := fieldType.Tag.Get("json")
-		// Ignore fields that are subsets of a primitive field.
-		if tag == "" {
-			continue
-		}
-
-		// Omitted field tags will contain ",omitempty", and ignored tags will
-		// match "-" exactly, respectively.
-		isOptionalField := strings.Contains(tag, ",omitempty") || tag == "-"
-		emptyVal := isEmptyValue(fieldValue)
-
-		newParentStructName := fieldType.Name
-		if parentStructName != "" {
-			newParentStructName = parentStructName + "." + newParentStructName
-		}
-
-		switch fieldValue.Kind() {
-		case reflect.Struct:
-			updateLog(result, "struct", newParentStructName, emptyVal, isOptionalField)
-			if !emptyVal {
-				checkMissingFields(result, fieldValue, newParentStructName)
-			}
-		default:
-			updateLog(result, "field", newParentStructName, emptyVal, isOptionalField)
-		}
-	}
-}
-
 // Returns updated error log with missing optional/mandatory field/struct objects.
 func updateLog(result *errors.ManifestResult, typeName string, newParentStructName string, emptyVal bool, isOptionalField bool) {
 	if !emptyVal {

pkg/validation/internal/typecheck.go

@@ -0,0 +1,49 @@
+package internal
+
+import (
+	"reflect"
+	"strings"
+
+	"github.com/operator-framework/api/pkg/validation/errors"
+)
+
+// Recursive function that traverses a nested struct passed in as reflect
+// value, and reports for errors/warnings in case of nil struct field values.
+// TODO: make iterative
+func checkMissingFields(result *errors.ManifestResult, v reflect.Value, parentStructName string) {
+	if v.Kind() != reflect.Struct {
+		return
+	}
+	typ := v.Type()
+
+	for i := 0; i < v.NumField(); i++ {
+		fieldValue := v.Field(i)
+		fieldType := typ.Field(i)
+
+		tag := fieldType.Tag.Get("json")
+		// Ignore fields that are subsets of a primitive field.
+		if tag == "" {
+			continue
+		}
+
+		// Omitted field tags will contain ",omitempty", and ignored tags will
+		// match "-" exactly, respectively.
+		isOptionalField := strings.Contains(tag, ",omitempty") || tag == "-"
+		emptyVal := isEmptyValue(fieldValue)
+
+		newParentStructName := fieldType.Name
+		if parentStructName != "" {
+			newParentStructName = parentStructName + "." + newParentStructName
+		}
+
+		switch fieldValue.Kind() {
+		case reflect.Struct:
+			updateLog(result, "struct", newParentStructName, emptyVal, isOptionalField)
+			if !emptyVal {
+				checkMissingFields(result, fieldValue, newParentStructName)
+			}
+		default:
+			updateLog(result, "field", newParentStructName, emptyVal, isOptionalField)
+		}
+	}
+}