-
Notifications
You must be signed in to change notification settings - Fork 26
Re-add --webhook-bind-address and pprof-bind-address flag #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Re-add --webhook-bind-address and pprof-bind-address flag #311
Conversation
Re-adds optional pprof profiling endpoint configuration via --pprof-bind-address flag, matching neutron-operator implementation. Disabled by default (empty string). Re-adds support for configuring the webhook server port through the --webhook-bind-address command-line flag (default: 9443). This flag was removed in the sdk update and needs to be restored to support local development and testing scenarios. Signed-off-by: Martin Schuppert <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8a94b6b93bf842a78aa142779574caf1 ✔️ openstack-meta-content-provider-master SUCCESS in 1h 28m 49s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a5302db16ba84dc09260148d5c4c94ac ✔️ openstack-meta-content-provider-master SUCCESS in 3h 12m 05s |
Tempest failures. Unrelated. |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/011ad449e805410889ecf57b8002e207 ✔️ openstack-meta-content-provider-master SUCCESS in 2h 48m 47s |
Re-adds optional pprof profiling endpoint configuration via --pprof-bind-address flag, matching neutron-operator implementation. Disabled by default (empty string).
Re-adds support for configuring the webhook server port through the --webhook-bind-address command-line flag (default: 9443).
This flag was removed in the sdk update and needs to be restored to support local development and testing scenarios.