Bug 1983612: Make InstanceCreate idempotent #189
Conversation
openshift-ci
bot
added
the
bugzilla/severity-low
|
@pierreprinetti: This pull request references Bugzilla bug 1983612, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: eurijon. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pierreprinetti
force-pushed
the
bz1983612
branch
from
6511fc1 to
c27e2ee
Compare
|
@pierreprinetti: This pull request references Bugzilla bug 1983612, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: eurijon. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This patch can be seen as a completion to #188. |
pkg/cloud/openstack/clients/utils.go
Outdated
| IDs := make([]string, 0, len(all)) | ||
| for _, s := range all { | ||
| if s.Name == name { | ||
| IDs = append(IDs, s.ID) |
|
/lgtm |
|
The discussion I'd like to have in this PR (and the reason why I didn't include this fix in #188 ), is whether it is OK to blindly delete volumes by name. WDYT? |
pierreprinetti
force-pushed
the
bz1983612
branch
from
c27e2ee to
7779fd8
Compare
|
Changed the IDsFromName utils function to match the corresponding new gophercloud/utils function exactly |
Prior to this change, if machine-controller gets reprovisioned in the middle of running InstanceCreate, stale volumes might be left on the cluster. With this change, before creating a new root volume for an instance, InstanceCreate deletes any volumes with the same name.
pierreprinetti
force-pushed
the
bz1983612
branch
from
7779fd8 to
6f2c304
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@pierreprinetti: All pull requests linked via external trackers have merged: Bugzilla bug 1983612 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* move rbac from hard code to generate use control-gen tool to generate rbac/rbac_role*.yaml files instead of hard code them Fixes openshift#155 * make crd file generated automatically use go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go crd to create instead of using hard code
3 participants
Prior to this change, if machine-controller gets reprovisioned in the
middle of running InstanceCreate, stale volumes might be left on the
cluster.
With this change, before creating a new root volume for an instance,
InstanceCreate deletes any volumes with the same name.