-
Notifications
You must be signed in to change notification settings - Fork 33
Bug 1952179: Port Allowed Address Pairs UI #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1952179: Port Allowed Address Pairs UI #178
Conversation
The allowed Address pairs were using the gohpercloud ports.allowed address pairs struct. This prevents us from being in control of the api, and may lead to unexpected updates. This also causes the names in the api to be underscored instead of camel case, which is inconsistent.
|
@iamemilio: This pull request references Bugzilla bug 1952179, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@iamemilio: All pull requests linked via external trackers have merged: Bugzilla bug 1952179 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Tagged resouces networks, subnet and router with `cluster-api-provider-openstack` and the cluster name in form of `<namespace>/<name>`.
The allowed Address pairs were using the gohpercloud ports.allowed
address pairs struct. This prevents us from being in control of the api,
and may lead to unexpected updates. This also causes the names in the
api to be underscored instead of camel case, which is inconsistent.